1772032 - Crash in [@ nsContentUtils::GetLinkLocation]

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/a481f791-4f70-4186-822c-3da5b0220531

Reason: SIGSEGV / SEGV_MAPERR

Top 10 frames of crashing thread:

0 libxul.so nsContentUtils::GetLinkLocation dom/base/nsContentUtils.cpp:5657
1 libxul.so mozilla::a11y::SessionAccessibility::PopulateNodeInfo accessible/android/SessionAccessibility.cpp:855
2 libxul.so nsAppShell::LambdaEvent<mozilla::a11y::SessionAccessibility::GetNodeInfo widget/android/nsAppShell.h:71
3 libxul.so nsAppShell::LambdaEvent<nsAppShell::SyncRunEvent widget/android/nsAppShell.h:71
4 libxul.so NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:465
5 libxul.so mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:85
6 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:355
7 libxul.so nsBaseAppShell::Run widget/nsBaseAppShell.cpp:137
8 libxul.so nsAppStartup::Run toolkit/components/startup/nsAppStartup.cpp:295
9 libxul.so XREMain::XRE_main toolkit/xre/nsAppRunner.cpp:5916

This looks like another crash related to recent accessibility changes on Android. Null deref crash.

Comment 1

[Eitan Isaacson [:eeejay]]

When a local doc shuts down it releases its ref to the presshell which we need for de-registering accessibles in its subtree.

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1772032 - Use DOM document node for getting SessionAcc instance. r?Jamie

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/516dad1c0595
Use DOM document node for getting SessionAcc instance. r=Jamie

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing geckoview-junit failures

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b45920d22e34
Use DOM document node for getting SessionAcc instance. r=Jamie

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b45920d22e34

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:eeejay, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Eitan Isaacson [:eeejay]]

Comment on attachment 9279301 [details]
Bug 1772032 - Use DOM document node for getting SessionAcc instance. r?Jamie

Beta/Release Uplift Approval Request

• User impact if declined: Potential crash
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a minor change that only affects edge cases.
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9279301 [details]
Bug 1772032 - Use DOM document node for getting SessionAcc instance. r?Jamie

Approved for 102 beta 6, thanks.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/5a5480949bbc