1772050 - Don't call Attributes in HandleLiveRegionEvent

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[James Teh [:Jamie]]

HandleLiveRegionEvent currently calls Attributes to determine whether something is a live region. This is potentially needlessly expensive because it will calculate group attributes, which might even involve building a CachedTableAccessible. We should instead use nsAccUtils::SetLiveContainerAttributes, which will just deal with the live region attributes.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1772050: Don't call Attributes() in Android's HandleLiveRegionEvent.

Attributes() might do computation that we'll just throw away; e.g. building a CachedTableAccessible.
In a content process, cached data structures like this will never get used by a client, so building them will always be wasteful.
Instead, use nsAccUtils::SetLiveContainerAttributes, which only computes live region stuff.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9acc4829d49
Don't call Attributes() in Android's HandleLiveRegionEvent. r=eeejay

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c9acc4829d49