1772090 - repair/implement about:processes on OpenBSD

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Landry Breuil (:gaston)]

Attachment: patch-toolkit_components_processtools_ProcInfo_linux_cpp

i'm pretty sure i saw working at some point on OpenBSD (but maybe i dreamt it since bug #1502917 seems to say its tier-1 only), but as of mozilla-beta or esr91, right now about:processes stays empty on OpenBSD.

An openbsd developer sent me a wip patch to add support for OpenBSD, which i'm attaching as-is. Will test it on top of 102.0b1, then refine it to upstream it properly.

Feedback on the patch as is itself much welcome, dunno if something similar is planned for FreeBSD/NetBSD.

Comment 1

[Andrew McCreight [:mccr8]]

Comment on attachment 9279072 [details] [diff] [review]
patch-toolkit_components_processtools_ProcInfo_linux_cpp

Review of attachment 9279072 [details] [diff] [review]:
-----------------------------------------------------------------

Jed's a better person to get feedback from than me. I don't really know any of this low level stuff.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 9279072 [details] [diff] [review]
patch-toolkit_components_processtools_ProcInfo_linux_cpp

Plus glandium and karlt in case they have thoughts

Comment 3

[Landry Breuil (:gaston)]

fwiw i've been able to successfully test the patch on top of 102.0b2 and it works fine (eg displays processes, tabs, memory/cpu usage)

Comment 4

[:gerard-majax]

Comment on attachment 9279072 [details] [diff] [review]
patch-toolkit_components_processtools_ProcInfo_linux_cpp

I'm not sure I'm the best qualified, but it looks good.

Comment 5

[Landry Breuil (:gaston)]

Attachment: Bug 1772090 - implement about:processes on OpenBSD r?glandium,gerald,jld

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 7

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8bc03d5f523
implement about:processes on OpenBSD r=glandium,jld,gerald

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a8bc03d5f523