Closed Bug 1772090 Opened 2 years ago Closed 2 years ago

repair/implement about:processes on OpenBSD

Categories

(Core :: IPC, enhancement)

All
OpenBSD
enhancement

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox105 --- fixed

People

(Reporter: gaston, Assigned: gaston)

Details

Attachments

(1 file, 1 obsolete file)

i'm pretty sure i saw working at some point on OpenBSD (but maybe i dreamt it since bug #1502917 seems to say its tier-1 only), but as of mozilla-beta or esr91, right now about:processes stays empty on OpenBSD.

An openbsd developer sent me a wip patch to add support for OpenBSD, which i'm attaching as-is. Will test it on top of 102.0b1, then refine it to upstream it properly.

Feedback on the patch as is itself much welcome, dunno if something similar is planned for FreeBSD/NetBSD.

Attachment #9279072 - Flags: feedback?(lissyx+mozillians)
Attachment #9279072 - Flags: feedback?(continuation)
Comment on attachment 9279072 [details] [diff] [review]
patch-toolkit_components_processtools_ProcInfo_linux_cpp

Review of attachment 9279072 [details] [diff] [review]:
-----------------------------------------------------------------

Jed's a better person to get feedback from than me. I don't really know any of this low level stuff.
Attachment #9279072 - Flags: feedback?(continuation) → feedback?(jld)

Comment on attachment 9279072 [details] [diff] [review]
patch-toolkit_components_processtools_ProcInfo_linux_cpp

Plus glandium and karlt in case they have thoughts

Attachment #9279072 - Flags: feedback?(mh+mozilla)
Attachment #9279072 - Flags: feedback?(karlt)

fwiw i've been able to successfully test the patch on top of 102.0b2 and it works fine (eg displays processes, tabs, memory/cpu usage)

Comment on attachment 9279072 [details] [diff] [review]
patch-toolkit_components_processtools_ProcInfo_linux_cpp

I'm not sure I'm the best qualified, but it looks good.

Attachment #9279072 - Flags: feedback?(lissyx+mozillians) → feedback+
Assignee: nobody → landry
Attachment #9282967 - Attachment description: WIP: Bug 1772090 - implement about:processes on OpenBSD → Bug 1772090 - implement about:processes on OpenBSD r?glandium,karlt,jld
Status: NEW → ASSIGNED
Attachment #9282967 - Attachment description: Bug 1772090 - implement about:processes on OpenBSD r?glandium,karlt,jld → Bug 1772090 - implement about:processes on OpenBSD r?glandium,gerald,jld
Attachment #9279072 - Flags: feedback?(karlt)
Attachment #9279072 - Flags: feedback?(jld) → feedback+
Attachment #9279072 - Attachment is obsolete: true
Attachment #9279072 - Flags: feedback?(mh+mozilla)
Attachment #9279072 - Flags: feedback+
Assignee: nobody → landry

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Status: NEW → ASSIGNED
Pushed by alissy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8bc03d5f523
implement about:processes on OpenBSD r=glandium,jld,gerald
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: