1772100 - Use plain object for lazy getter in browser/components/

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[Tooru Fujisawa [:arai]]

+++ This bug was initially created as a clone of Bug #1772007 +++

Many JSM files define lazy getters on the per-JSM global this object.
The global this object doesn't exist in ES module, and those lazy getters need to be moved to a plain object const lazy = {};, and each consumer needs to be rewritten to refer the lazy getter with lazy.foo.

This migration is done by automated script in bug 1608279.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 1: Use plain object for lazy getter in browser/components/aboutlogins/. r?MattN

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 2: Use plain object for lazy getter in browser/components/attribution/. r?mixedpuppy!

Depends on D148011

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 3: Use plain object for lazy getter in browser/components/customizableui/. r?Gijs!

Depends on D148012

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 4: Use plain object for lazy getter in browser/components/doh/. r?#necko-reviewers

Depends on D148013

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 5: Use plain object for lazy getter in browser/components/downloads/. r?mak

Depends on D148014

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 6: Use plain object for lazy getter in browser/components/downloads/DownloadsViewUI.jsm. r?mak

Depends on D148015

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 7: Use plain object for lazy getter in browser/components/enterprisepolicies/. r?mkaply

Depends on D148016

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 8: Use plain object for lazy getter in browser/components/extensions/. r?#extension-reviewers

Depends on D148017

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 9: Use plain object for lazy getter in browser/components/migration/. r?MattN

Depends on D148018

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 10: Use plain object for lazy getter in browser/components/newtab/. r?Mardak

Depends on D148019

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 11: Use plain object for lazy getter in browser/components/pagedata/. r?mossop

Depends on D148020

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 12: Use plain object for lazy getter in browser/components/places/. r?mossop

Depends on D148021

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 13: Use plain object for lazy getter in browser/components/pocket/. r?mccr8

Depends on D148022

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 14: Use plain object for lazy getter in browser/components/screenshots/. r?sfoster

Depends on D148023

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 15: Use plain object for lazy getter in browser/components/search/. r?daleharvey

Depends on D148024

Comment 16

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 16: Use plain object for lazy getter in browser/components/sessionstore/. r?nika

Depends on D148025

Comment 17

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 17: Use plain object for lazy getter in browser/components/shell/. r?bytesized

Depends on D148026

Comment 18

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 18: Use plain object for lazy getter in browser/components/syncedtabs/. r?markh

Depends on D148027

Comment 19

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 19: Use plain object for lazy getter in browser/components/translation/. r?florian

Depends on D148028

Comment 20

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 20: Use plain object for lazy getter in browser/components/uitour/. r?MattN

Depends on D148029

Comment 21

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 21: Use plain object for lazy getter in browser/components/urlbar/. r?adw

Depends on D148030

Comment 22

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 22: Use plain object for lazy getter in browser/components/urlbar/UrlbarProviderInterventions.jsm. r?adw

Depends on D148031

Comment 23

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 23: Use plain object for lazy getter in browser/components/. r?mossop

Depends on D148032

Comment 24

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772100 - Part 24: Use plain object for lazy getter in browser/components/BrowserGlue.jsm. r?mak

Depends on D148033

Comment 25

[Mike Kaply [:mkaply]]

If anyone wants additional context on this change, see:

https://docs.google.com/document/d/1LjKkl-hSnXy82r0QO6XWg-A7TbJ9EkCvaQOqP_YgwtQ/edit?disco=AAAAZTiOQgA

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/141d1fdc23e2
Part 1: Use plain object for lazy getter in browser/components/aboutlogins/. r=MattN
https://hg.mozilla.org/integration/autoland/rev/589039df2fde
Part 7: Use plain object for lazy getter in browser/components/enterprisepolicies/. r=mkaply
https://hg.mozilla.org/integration/autoland/rev/1cfa66fd3072
Part 8: Use plain object for lazy getter in browser/components/extensions/. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/64d89a5aa77e
Part 9: Use plain object for lazy getter in browser/components/migration/. r=MattN
https://hg.mozilla.org/integration/autoland/rev/a545a6bcd393
Part 10: Use plain object for lazy getter in browser/components/newtab/. r=Mardak
https://hg.mozilla.org/integration/autoland/rev/44856311c4d0
Part 11: Use plain object for lazy getter in browser/components/pagedata/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/a8e1e90b200a
Part 12: Use plain object for lazy getter in browser/components/places/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/a0b40177951c
Part 14: Use plain object for lazy getter in browser/components/screenshots/. r=niklas
https://hg.mozilla.org/integration/autoland/rev/a86e022cdd9a
Part 16: Use plain object for lazy getter in browser/components/sessionstore/. r=nika
https://hg.mozilla.org/integration/autoland/rev/378d82b22cfd
Part 17: Use plain object for lazy getter in browser/components/shell/. r=bytesized
https://hg.mozilla.org/integration/autoland/rev/8ad45e6a2231
Part 18: Use plain object for lazy getter in browser/components/syncedtabs/. r=markh
https://hg.mozilla.org/integration/autoland/rev/1cc5f6b081cd
Part 19: Use plain object for lazy getter in browser/components/translation/. r=florian
https://hg.mozilla.org/integration/autoland/rev/d8ea83a7f82a
Part 20: Use plain object for lazy getter in browser/components/uitour/. r=MattN
https://hg.mozilla.org/integration/autoland/rev/12823192db08
Part 23: Use plain object for lazy getter in browser/components/. r=mossop

Comment 27

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/141d1fdc23e2
https://hg.mozilla.org/mozilla-central/rev/589039df2fde
https://hg.mozilla.org/mozilla-central/rev/1cfa66fd3072
https://hg.mozilla.org/mozilla-central/rev/64d89a5aa77e
https://hg.mozilla.org/mozilla-central/rev/a545a6bcd393
https://hg.mozilla.org/mozilla-central/rev/44856311c4d0
https://hg.mozilla.org/mozilla-central/rev/a8e1e90b200a
https://hg.mozilla.org/mozilla-central/rev/a0b40177951c
https://hg.mozilla.org/mozilla-central/rev/a86e022cdd9a
https://hg.mozilla.org/mozilla-central/rev/378d82b22cfd
https://hg.mozilla.org/mozilla-central/rev/8ad45e6a2231
https://hg.mozilla.org/mozilla-central/rev/1cc5f6b081cd
https://hg.mozilla.org/mozilla-central/rev/d8ea83a7f82a
https://hg.mozilla.org/mozilla-central/rev/12823192db08

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05a015bd4783
Part 4: Use plain object for lazy getter in browser/components/doh/. r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/cacf593bf250
Part 5: Use plain object for lazy getter in browser/components/downloads/. r=mak
https://hg.mozilla.org/integration/autoland/rev/7d34a43bda82
Part 6: Use plain object for lazy getter in browser/components/downloads/DownloadsViewUI.jsm. r=mak
https://hg.mozilla.org/integration/autoland/rev/672ad1a7c2f9
Part 15: Use plain object for lazy getter in browser/components/search/. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/b8a1318e4c13
Part 24: Use plain object for lazy getter in browser/components/BrowserGlue.jsm. r=mak

Comment 29

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/05a015bd4783
https://hg.mozilla.org/mozilla-central/rev/cacf593bf250
https://hg.mozilla.org/mozilla-central/rev/7d34a43bda82
https://hg.mozilla.org/mozilla-central/rev/672ad1a7c2f9
https://hg.mozilla.org/mozilla-central/rev/b8a1318e4c13

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d8051c9372c
Part 2: Use plain object for lazy getter in browser/components/attribution/. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/708f5fd81d4e
Part 13: Use plain object for lazy getter in browser/components/pocket/. r=thecount

Comment 31

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0d8051c9372c
https://hg.mozilla.org/mozilla-central/rev/708f5fd81d4e

Comment 32

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e52a65341944
Part 3: Use plain object for lazy getter in browser/components/customizableui/. r=Gijs

Comment 33

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e52a65341944

Comment 34

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #32)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e52a65341944
Part 3: Use plain object for lazy getter in
browser/components/customizableui/. r=Gijs

== Change summary for alert #34430 (as of Sat, 11 Jun 2022 18:20:57 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
16%	microsoft loadtime	linux1804-64-shippable-qr	cold fission webrender	375.69 -> 316.54
15%	ebay fcp	linux1804-64-shippable-qr	cold fission webrender	376.04 -> 317.79
15%	ebay fcp	macosx1015-64-shippable-qr	cold fission webrender	301.31 -> 256.12
14%	ebay loadtime	macosx1015-64-shippable-qr	cold fission webrender	463.17 -> 396.62
13%	microsoft fcp	linux1804-64-shippable-qr	cold fission webrender	293.08 -> 254.83
...	...	...	...	...
3%	ebay SpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	1,427.54 -> 1,380.67

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34430