1772101 - Use plain object for lazy getter in toolkit/components/

Status: RESOLVED FIXED

(Toolkit :: General, task)

Description

[Tooru Fujisawa [:arai]]

+++ This bug was initially created as a clone of Bug #1772007 +++

Many JSM files define lazy getters on the per-JSM global this object.
The global this object doesn't exist in ES module, and those lazy getters need to be moved to a plain object const lazy = {};, and each consumer needs to be rewritten to refer the lazy getter with lazy.foo.

This migration is done by automated script in bug 1608279.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 1: Use plain object for lazy getter in toolkit/components/antitracking/. r?baku

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 2: Use plain object for lazy getter in toolkit/components/asyncshutdown/. r?mconley

Depends on D147941

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 3: Use plain object for lazy getter in toolkit/components/backgroundhangmonitor/. r?mconley

Depends on D147942

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 4: Use plain object for lazy getter in toolkit/components/backgroundtasks/. r?mossop

Depends on D147943

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 5: Use plain object for lazy getter in toolkit/components/bitsdownload/. r?bytesized

Depends on D147944

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 6: Use plain object for lazy getter in toolkit/components/captivedetect/. r?dragana

Depends on D147945

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 7: Use plain object for lazy getter in toolkit/components/cleardata/. r?baku

Depends on D147946

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 8: Use plain object for lazy getter in toolkit/components/contentprefs/. r?mak

Depends on D147947

Comment 9

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 9: Use plain object for lazy getter in toolkit/components/contextualidentity/. r?baku

Depends on D147948

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 10: Use plain object for lazy getter in toolkit/components/corroborator/. r?kmag

Depends on D147949

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 11: Use plain object for lazy getter in toolkit/components/crashes/. r?gsvelto

Depends on D147950

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 12: Use plain object for lazy getter in toolkit/components/downloads/. r?mak

Depends on D147951

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 13: Use plain object for lazy getter in toolkit/components/downloads/DownloadCore.jsm. r?mak

Depends on D147952

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 14: Use plain object for lazy getter in toolkit/components/downloads/DownloadIntegration.jsm. r?mak

Depends on D147953

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 15: Use plain object for lazy getter in toolkit/components/downloads/Downloads.jsm. r?mak

Depends on D147955

Comment 16

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 16: Use plain object for lazy getter in toolkit/components/enterprisepolicies/. r?mkaply

Depends on D147956

Comment 17

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 17: Use plain object for lazy getter in toolkit/components/extensions/. r?#extension-reviewers

Depends on D147957

Comment 18

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 18: Use plain object for lazy getter in toolkit/components/extensions/ExtensionShortcuts.jsm. r?#extension-reviewers

Depends on D147958

Comment 19

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 19: Use plain object for lazy getter in toolkit/components/featuregates/. r?jaws

Depends on D147959

Comment 20

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 20: Use plain object for lazy getter in toolkit/components/formautofill/. r?sgalich

Depends on D147960

Comment 21

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 21: Use plain object for lazy getter in toolkit/components/messaging-system/. r?pdahiya

Depends on D147961

Comment 22

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 22: Use plain object for lazy getter in toolkit/components/narrate/. r?jaws

Depends on D147962

Comment 23

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 23: Use plain object for lazy getter in toolkit/components/nimbus/. r?emcminn!

Depends on D147963

Comment 24

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 24: Use plain object for lazy getter in toolkit/components/normandy/. r?chutten

Depends on D147964

Comment 25

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 25: Use plain object for lazy getter in toolkit/components/normandy/lib/Heartbeat.jsm. r?chutten

Depends on D147965

Comment 26

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 26: Use plain object for lazy getter in toolkit/components/normandy/lib/NormandyApi.jsm. r?chutten

Depends on D147966

Comment 27

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 27: Use plain object for lazy getter in toolkit/components/osfile/. r?mossop

Depends on D147967

Comment 28

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 28: Use plain object for lazy getter in toolkit/components/passwordmgr/. r?MattN

Depends on D147968

Comment 29

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 29: Use plain object for lazy getter in toolkit/components/pdfjs/content/. r?calixte

Depends on D147969

Comment 30

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 30: Use plain object for lazy getter in toolkit/components/pdfjs/. r?calixte

Depends on D147970

Comment 31

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 31: Use plain object for lazy getter in toolkit/components/pictureinpicture/. r?mconley

Depends on D147971

Comment 32

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 32: Use plain object for lazy getter in toolkit/components/places/. r?mak

Depends on D147972

Comment 33

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 33: Use plain object for lazy getter in toolkit/components/promiseworker/. r?florian

Depends on D147973

Comment 34

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 34: Use plain object for lazy getter in toolkit/components/prompts/. r?florian

Depends on D147974

Comment 35

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 35: Use plain object for lazy getter in toolkit/components/reader/. r?jaws

Depends on D147975

Comment 36

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 36: Use plain object for lazy getter in toolkit/components/remotebrowserutils/. r?mconley

Depends on D147976

Comment 37

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 37: Use plain object for lazy getter in toolkit/components/remotepagemanager/. r?mossop

Depends on D147977

Comment 38

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 38: Use plain object for lazy getter in toolkit/components/satchel/. r?MattN

Depends on D147978

Comment 39

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 39: Use plain object for lazy getter in toolkit/components/search/. r?daleharvey

Depends on D147979

Comment 40

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 40: Remove lazy getter from toolkit/components/sessionstore/. r?nika

Depends on D147980

Comment 41

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 41: Use plain object for lazy getter in toolkit/components/taskscheduler/. r?nalexander

Depends on D147981

Comment 42

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 42: Use plain object for lazy getter in toolkit/components/telemetry/. r?chutten

Depends on D147982

Comment 43

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 43: Use plain object for lazy getter in toolkit/components/terminator/. r?chutten

Depends on D147983

Comment 44

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 44: Use plain object for lazy getter in toolkit/components/thumbnails/. r?adw

Depends on D147984

Comment 45

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 45: Use plain object for lazy getter in toolkit/components/timermanager/. r?kmag

Depends on D147985

Comment 46

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 46: Use plain object for lazy getter in toolkit/components/url-classifier/. r?gcp

Depends on D147986

Comment 47

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 47: Use plain object for lazy getter in toolkit/components/urlformatter/. r?glandium

Depends on D147987

Comment 48

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 48: Use plain object for lazy getter in toolkit/components/utils/. r?florian

Depends on D147988

Comment 49

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 49: Use plain object for lazy getter in toolkit/components/xulstore/. r?smaug

Depends on D147989

Comment 50

[Tooru Fujisawa [:arai]]

Attachment: Bug 1772101 - Part 50: Use plain object for FormAutofill.defineLazyLogGetter in toolkit/components/formautofill/. r?dimi

Depends on D147990

Comment 51

[Mike Kaply [:mkaply]]

If anyone wants additional context on this change, see:

https://docs.google.com/document/d/1LjKkl-hSnXy82r0QO6XWg-A7TbJ9EkCvaQOqP_YgwtQ/edit?disco=AAAAZTiOQgA

Comment 52

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49fb891fead5
Part 1: Use plain object for lazy getter in toolkit/components/antitracking/. r=anti-tracking-reviewers,pbz
https://hg.mozilla.org/integration/autoland/rev/93a3309a4496
Part 2: Use plain object for lazy getter in toolkit/components/asyncshutdown/. r=mconley
https://hg.mozilla.org/integration/autoland/rev/a5a2d7d05f25
Part 3: Use plain object for lazy getter in toolkit/components/backgroundhangmonitor/. r=mconley
https://hg.mozilla.org/integration/autoland/rev/b3638cb4c65f
Part 4: Use plain object for lazy getter in toolkit/components/backgroundtasks/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/b08530ee12c0
Part 5: Use plain object for lazy getter in toolkit/components/bitsdownload/. r=bytesized
https://hg.mozilla.org/integration/autoland/rev/c000876e7acb
Part 9: Use plain object for lazy getter in toolkit/components/contextualidentity/. r=florian
https://hg.mozilla.org/integration/autoland/rev/bea6f66aaddb
Part 10: Use plain object for lazy getter in toolkit/components/corroborator/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/bb16d84c55fa
Part 11: Use plain object for lazy getter in toolkit/components/crashes/. r=gsvelto
https://hg.mozilla.org/integration/autoland/rev/b56aa3c65e4c
Part 16: Use plain object for lazy getter in toolkit/components/enterprisepolicies/. r=mkaply
https://hg.mozilla.org/integration/autoland/rev/47bea50b1999
Part 17: Use plain object for lazy getter in toolkit/components/extensions/. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/aeb84c394d41
Part 18: Use plain object for lazy getter in toolkit/components/extensions/ExtensionShortcuts.jsm. r=mixedpuppy,extension-reviewers
https://hg.mozilla.org/integration/autoland/rev/3dcfab6e51ca
Part 20: Use plain object for lazy getter in toolkit/components/formautofill/. r=sgalich
https://hg.mozilla.org/integration/autoland/rev/9f53e4ef70f2
Part 21: Use plain object for lazy getter in toolkit/components/messaging-system/. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/843821737501
Part 24: Use plain object for lazy getter in toolkit/components/normandy/. r=barret
https://hg.mozilla.org/integration/autoland/rev/e63b0e29eabf
Part 26: Use plain object for lazy getter in toolkit/components/normandy/lib/NormandyApi.jsm. r=barret
https://hg.mozilla.org/integration/autoland/rev/6f75955bb7be
Part 27: Use plain object for lazy getter in toolkit/components/osfile/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/6a057d4d0b5f
Part 28: Use plain object for lazy getter in toolkit/components/passwordmgr/. r=MattN
https://hg.mozilla.org/integration/autoland/rev/d7ddeeeaee98
Part 29: Use plain object for lazy getter in toolkit/components/pdfjs/content/. r=calixte
https://hg.mozilla.org/integration/autoland/rev/8dfd7f245dba
Part 30: Use plain object for lazy getter in toolkit/components/pdfjs/. r=calixte
https://hg.mozilla.org/integration/autoland/rev/febcddd665ca
Part 31: Use plain object for lazy getter in toolkit/components/pictureinpicture/. r=mconley
https://hg.mozilla.org/integration/autoland/rev/c98449683f2b
Part 33: Use plain object for lazy getter in toolkit/components/promiseworker/. r=florian
https://hg.mozilla.org/integration/autoland/rev/b44f313eb8f4
Part 34: Use plain object for lazy getter in toolkit/components/prompts/. r=florian
https://hg.mozilla.org/integration/autoland/rev/84711ce05a54
Part 36: Use plain object for lazy getter in toolkit/components/remotebrowserutils/. r=mconley
https://hg.mozilla.org/integration/autoland/rev/de69106900f3
Part 37: Use plain object for lazy getter in toolkit/components/remotepagemanager/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/3b2c2cd07f7f
Part 38: Use plain object for lazy getter in toolkit/components/satchel/. r=MattN
https://hg.mozilla.org/integration/autoland/rev/0010b6d7628a
Part 40: Remove lazy getter from toolkit/components/sessionstore/. r=nika
https://hg.mozilla.org/integration/autoland/rev/fea3451ad116
Part 41: Use plain object for lazy getter in toolkit/components/taskscheduler/. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/1cd69dac03f2
Part 42: Use plain object for lazy getter in toolkit/components/telemetry/. r=chutten
https://hg.mozilla.org/integration/autoland/rev/8afa95245f4a
Part 43: Use plain object for lazy getter in toolkit/components/terminator/. r=chutten
https://hg.mozilla.org/integration/autoland/rev/2bec86a7db24
Part 44: Use plain object for lazy getter in toolkit/components/thumbnails/. r=adw
https://hg.mozilla.org/integration/autoland/rev/975926ec5b6e
Part 45: Use plain object for lazy getter in toolkit/components/timermanager/. r=kmag
https://hg.mozilla.org/integration/autoland/rev/bb37f59772bf
Part 46: Use plain object for lazy getter in toolkit/components/url-classifier/. r=gcp
https://hg.mozilla.org/integration/autoland/rev/bd04a30f9185
Part 48: Use plain object for lazy getter in toolkit/components/utils/. r=florian
https://hg.mozilla.org/integration/autoland/rev/20e3dcce24ae
Part 49: Use plain object for lazy getter in toolkit/components/xulstore/. r=smaug
https://hg.mozilla.org/integration/autoland/rev/6348e6918e0d
Part 50: Use plain object for FormAutofill.defineLazyLogGetter  in toolkit/components/formautofill/. r=dimi

Comment 53

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/49fb891fead5
https://hg.mozilla.org/mozilla-central/rev/93a3309a4496
https://hg.mozilla.org/mozilla-central/rev/a5a2d7d05f25
https://hg.mozilla.org/mozilla-central/rev/b3638cb4c65f
https://hg.mozilla.org/mozilla-central/rev/b08530ee12c0
https://hg.mozilla.org/mozilla-central/rev/c000876e7acb
https://hg.mozilla.org/mozilla-central/rev/bea6f66aaddb
https://hg.mozilla.org/mozilla-central/rev/bb16d84c55fa
https://hg.mozilla.org/mozilla-central/rev/b56aa3c65e4c
https://hg.mozilla.org/mozilla-central/rev/47bea50b1999
https://hg.mozilla.org/mozilla-central/rev/aeb84c394d41
https://hg.mozilla.org/mozilla-central/rev/3dcfab6e51ca
https://hg.mozilla.org/mozilla-central/rev/9f53e4ef70f2
https://hg.mozilla.org/mozilla-central/rev/843821737501
https://hg.mozilla.org/mozilla-central/rev/e63b0e29eabf
https://hg.mozilla.org/mozilla-central/rev/6f75955bb7be
https://hg.mozilla.org/mozilla-central/rev/6a057d4d0b5f
https://hg.mozilla.org/mozilla-central/rev/d7ddeeeaee98
https://hg.mozilla.org/mozilla-central/rev/8dfd7f245dba
https://hg.mozilla.org/mozilla-central/rev/febcddd665ca
https://hg.mozilla.org/mozilla-central/rev/c98449683f2b
https://hg.mozilla.org/mozilla-central/rev/b44f313eb8f4
https://hg.mozilla.org/mozilla-central/rev/84711ce05a54
https://hg.mozilla.org/mozilla-central/rev/de69106900f3
https://hg.mozilla.org/mozilla-central/rev/3b2c2cd07f7f
https://hg.mozilla.org/mozilla-central/rev/0010b6d7628a
https://hg.mozilla.org/mozilla-central/rev/fea3451ad116
https://hg.mozilla.org/mozilla-central/rev/1cd69dac03f2
https://hg.mozilla.org/mozilla-central/rev/8afa95245f4a
https://hg.mozilla.org/mozilla-central/rev/2bec86a7db24
https://hg.mozilla.org/mozilla-central/rev/975926ec5b6e
https://hg.mozilla.org/mozilla-central/rev/bb37f59772bf
https://hg.mozilla.org/mozilla-central/rev/bd04a30f9185
https://hg.mozilla.org/mozilla-central/rev/20e3dcce24ae
https://hg.mozilla.org/mozilla-central/rev/6348e6918e0d

Comment 54

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bac4ed151b3a
Part 7: Use plain object for lazy getter in toolkit/components/cleardata/. r=pbz
https://hg.mozilla.org/integration/autoland/rev/6d059743dca3
Part 8: Use plain object for lazy getter in toolkit/components/contentprefs/. r=mak
https://hg.mozilla.org/integration/autoland/rev/99f097b1f546
Part 12: Use plain object for lazy getter in toolkit/components/downloads/. r=mak
https://hg.mozilla.org/integration/autoland/rev/6ef1eabd31dc
Part 13: Use plain object for lazy getter in toolkit/components/downloads/DownloadCore.jsm. r=mak
https://hg.mozilla.org/integration/autoland/rev/dce66a729e3d
Part 14: Use plain object for lazy getter in toolkit/components/downloads/DownloadIntegration.jsm. r=mak
https://hg.mozilla.org/integration/autoland/rev/3b2091b4dc4a
Part 15: Use plain object for lazy getter in toolkit/components/downloads/Downloads.jsm. r=mak
https://hg.mozilla.org/integration/autoland/rev/772c62964183
Part 19: Use plain object for lazy getter in toolkit/components/featuregates/. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/145b3ab52b71
Part 32: Use plain object for lazy getter in toolkit/components/places/. r=mak
https://hg.mozilla.org/integration/autoland/rev/a40f297f91e7
Part 35: Use plain object for lazy getter in toolkit/components/reader/. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/6ad5d02566fc
Part 39: Use plain object for lazy getter in toolkit/components/search/. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/05c45aacc36e
Part 47: Use plain object for lazy getter in toolkit/components/urlformatter/. r=Gijs

Comment 55

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/bac4ed151b3a
https://hg.mozilla.org/mozilla-central/rev/6d059743dca3
https://hg.mozilla.org/mozilla-central/rev/99f097b1f546
https://hg.mozilla.org/mozilla-central/rev/6ef1eabd31dc
https://hg.mozilla.org/mozilla-central/rev/dce66a729e3d
https://hg.mozilla.org/mozilla-central/rev/3b2091b4dc4a
https://hg.mozilla.org/mozilla-central/rev/772c62964183
https://hg.mozilla.org/mozilla-central/rev/145b3ab52b71
https://hg.mozilla.org/mozilla-central/rev/a40f297f91e7
https://hg.mozilla.org/mozilla-central/rev/6ad5d02566fc
https://hg.mozilla.org/mozilla-central/rev/05c45aacc36e

Comment 56

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d7ad602705b
Part 23: Use plain object for lazy getter in toolkit/components/nimbus/. r=emcminn

Comment 57

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0d7ad602705b