Closed Bug 1772132 Opened 2 years ago Closed 2 years ago

Remove cargo_metadata replacement hack from m-c

Categories

(Data Platform and Tools :: Glean: SDK, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: janerik, Assigned: travis_)

References

Details

Attachments

(1 file)

In order to reduce crate duplication we added a hack to replace cargo_metadata 0.13 with cargo_metadata 0.14.2

That can be removed when we upgrade UniFFI in Glean and land that Glean update in m-c.

Summary: Remove semver replacement hack from m-c → Remove cargo_metadata replacement hack from m-c
Assignee: nobody → jrediger
Priority: P3 → P2
Whiteboard: [telemetry:glean-rs:m?]
Assignee: jrediger → tlong
Priority: P2 → P1
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ab4790cd94eb Update Glean and remove cargo metadata replacement. r=janerik,supply-chain-reviewers

Ah crap. I know the issue and can fix that shortly.

Thanks to :janerik I think we have this corrected and attempting landing again.

Flags: needinfo?(tlong)
Pushed by tlong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1ff9bb6e4a8c Update Glean and remove cargo metadata replacement. r=janerik,supply-chain-reviewers

Backed out for causing build bustage.

Failure line: Unsuccessful task run with exit code: 1 completed in 207.475 seconds

Push with failures

Failure log

Backout link

<...>
[task 2022-07-13T13:16:07.502Z]   Progress: 11% (135/1209)
[task 2022-07-13T13:16:07.503Z]   Progress: 11% (136/1209)
[task 2022-07-13T13:16:07.503Z]   Progress: 11% (137/1209)
[task 2022-07-13T13:16:07.503Z]   Progress: 11% (138/1209)
[task 2022-07-13T13:16:07.504Z]   Progress: 11% (139/1209)
[task 2022-07-13T13:16:07.505Z]   Progress: 11% (140/1209)
[task 2022-07-13T13:16:07.505Z]   Progress: 11% (141/1209)
[task 2022-07-13T13:16:07.506Z]   Progress: 11% (142/1209)/usr/local/lib/python2.7/dist-packages/flake8/engine.py:33: PkgResourcesDeprecationWarning: Parameters to load are deprecated.  Call .resolve and .require separately.
[task 2022-07-13T13:16:07.506Z]   checker = entry.load(require=False)
[task 2022-07-13T13:16:07.523Z] 
[task 2022-07-13T13:16:07.525Z]   Progress: 11% (143/1209)
[task 2022-07-13T13:16:07.525Z]   Progress: 11% (144/1209)
[task 2022-07-13T13:16:07.531Z]   Progress: 11% (145/1209)
[task 2022-07-13T13:16:07.533Z]   Progress: 12% (146/1209)
[task 2022-07-13T13:16:07.546Z]   Progress: 12% (147/1209)
[task 2022-07-13T13:16:07.562Z]   Progress: 12% (148/1209)
[task 2022-07-13T13:16:07.567Z]   Progress: 12% (149/1209)
<...>
[task 2022-07-13T13:16:08.268Z]   Progress: 99% (1201/1209)
[task 2022-07-13T13:16:08.275Z]   Progress: 99% (1202/1209)
[task 2022-07-13T13:16:08.285Z]   Progress: 99% (1203/1209)
[task 2022-07-13T13:16:08.306Z]   Progress: 99% (1204/1209)
[task 2022-07-13T13:16:08.315Z]   Progress: 99% (1205/1209)
[task 2022-07-13T13:16:08.332Z]   Progress: 99% (1206/1209)
[task 2022-07-13T13:16:08.341Z]   Progress: 99% (1207/1209)
[task 2022-07-13T13:16:08.365Z]   Progress: 99% (1208/1209)
[task 2022-07-13T13:16:08.367Z]   Progress: 100% (1209/1209)
[task 2022-07-13T13:16:08.367Z] Running the dependency licensing lint...
[task 2022-07-13T13:16:08.367Z] 
[taskcluster 2022-07-13 13:16:10.586Z] === Task Finished ===
[taskcluster 2022-07-13 13:16:10.586Z] Unsuccessful task run with exit code: 1 completed in 207.475 seconds


Flags: needinfo?(tlong)
Flags: needinfo?(tlong)

Looks like try was successful (for both Jan-Erik and my attempt at it). Let's see if I can not break things this time...

Pushed by tlong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce93635100b6 Update Glean and remove cargo metadata replacement. r=janerik,supply-chain-reviewers

Backed out for causing WebRender build bustage

Backout link

Push with failures

Failure log

Flags: needinfo?(tlong)

I've fixed the webrender build bustage by updating the semver dependency there to the same one used elsewhere. I have ran this on try two times now, both times I only see unrelated failures:
https://treeherder.mozilla.org/jobs?repo=try&revision=45a134305006441a6dfaff3d7ac73c6c20d7044c
https://treeherder.mozilla.org/jobs?repo=try&revision=8e47193392440f18a9025df458adba75cdd31732

Trying this again...

Flags: needinfo?(tlong)
Pushed by tlong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8a49ebbf7b9e Update Glean and remove cargo metadata replacement. r=janerik,supply-chain-reviewers
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Blocks: 1774585
Regressions: 1783790
No longer regressions: 1783790
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: