1772148 - Enable rkv-safe-mode everywhere

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

(to remove lmdb dependency from rkv).

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Hi Jan-Erik, last I heard that it should just be pref-flipping simple, is that still the case? Can I go ahead and write a PR?

Comment 2

[Jan-Erik Rediger [:janerik]]

We haven't yet rolled out a release to iOS, so on the Glean side this will take a bit longer to roll out.
But what we can do:

• Already remove lmdb from rkv and get it released.
• We'll do a Glean release with the old version but the pref-flip, so that it uses our migration code
• Then we can land an update of Glean+rkv in m-c (and subsequently on Android), where it's already not using lmdb anyway.
• We take care of rolling it out on iOS separately (that's on the Glean team)

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Already remove lmdb from rkv and get it released.

I don't think we can get anything good from this as we won't be able to actually deploy it without duplicating the dependency. I think I can wait rather than complicating the situation, unless something requires us to proceed earlier.

We'll do a Glean release with the old version but the pref-flip, so that it uses our migration code

So this is one of my concerns. How long should we keep the migration path?

Comment 4

[Jan-Erik Rediger [:janerik]]

(In reply to Kagami :saschanaz from comment #3)

So this is one of my concerns. How long should we keep the migration path?

Ah right, we probably want that around for a bit to ensure people upgrade.
I'll get you an answer + plan to that by the end of the week.

Comment 5

[Jan-Erik Rediger [:janerik]]

I have a rough plan ready, waiting for feedback from a colleague before sharing that more widely.

Comment 6

[Jan-Erik Rediger [:janerik]]

Attachment: Glean with safe-mode everywhere

Short proposal for how we want to go about this.
tl;dr: We're doing the pref-flip now, then we can evaluate rollout by Q4 and subsequently remove the migration code fully (and thus rkv can drop the dependency only by then)

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean/pull/2123

Comment 8

[Jan-Erik Rediger [:janerik]]

badboy merged PR #2123: "Bug 1772148 - Remove rkv safe-mode toggle. It's default enabled now." in a8a418a.

This is one part of the whole thing. We still need to release it and then track that around Q4 for completely removing migration.

Comment 9

[Jan-Erik Rediger [:janerik]]

Firefox iOS upgrade here: https://github.com/mozilla-mobile/firefox-ios/pull/11392

Comment 10

[Jan-Erik Rediger [:janerik]]

Glean v51 landed in Firefox iOS: https://github.com/mozilla-mobile/firefox-ios/pull/11407

Comment 11

[Jan-Erik Rediger [:janerik]]

Focus iOS also got the update: https://github.com/mozilla-mobile/focus-ios/pull/3386

Comment 12

[Jan-Erik Rediger [:janerik]]

It's starting to show up in nightly builds of Firefox and Focus. Closing this then.