1772168 - Screenshot preview is blank gray

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Steve Fink [:sfink] [:s:]]

Attachment: What I see when using the screenshot tool

In my current Nightly (103.0a1 (2022-05-31)), when I do a screenshot of a Google Calendar, I get a black screen. Dragging out a box shows as a blank gray box. The element highlighting still works. The resulting screenshot is correct.

Same thing for Google Sheets.

It works fine for the tab containing bugzilla.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: The downloaded screenshot

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Weird, I can reproduce this with my regular profile but not with a fresh profile created with mozregression on my Win10 system.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Reproduces in my Linux VM with a clean profile. FWIW, I was using Google Maps to test.

INFO: Last good revision: 0e968cbb3e1dbc6f6ef05f54adcca25afb1eb086
INFO: First bad revision: b109bc84b050be5db6e46d9f4af9b7e3e3445151
INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0e968cbb3e1dbc6f6ef05f54adcca25afb1eb086&tochange=b109bc84b050be5db6e46d9f4af9b7e3e3445151

Comment 4

[Sam Foster [:sfoster] (he/him)]

This seems to be a pretty recent regression. I would be good to know if there's some particular pref or something that the new profile doesn't have. It looks like the graphics layer decides the content under the injected iframe is fully occluded and doesn't paint it - but only in some cases?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Grr, I see what I missed, whoops...

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1772168 - Really ensure screenshot iframes are transparent. r=sfoster

Bug 1771487 fixed pages that followed the preferred color-scheme (e.g.,
bugzilla or so).

For pages that are forced-light, if you have a dark theme, the iframe
would get a dark preferred color-scheme, which causes the same issue we
were avoiding in the other case.

Instead, make sure the screenshots frames don't have any color-scheme
set (so they default to light), and explicitly set the color-scheme of
the iframe so that it matches.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e1926579b3b
Really ensure screenshot iframes are transparent. r=sfoster

Comment 8

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/6e1926579b3b

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9279292 [details]
Bug 1772168 - Really ensure screenshot iframes are transparent. r=sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0
• List of other uplifts needed: nome
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple front end change.
• String changes made/needed: none
• Is Android affected?: No

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1771487

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9279292 [details]
Bug 1772168 - Really ensure screenshot iframes are transparent. r=sfoster

Fix for a visible front-end regression, approved for 102 beta 4, thanks.

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/89e59122f2ac

Comment 14

[Ardelean Oana, Desktop QA [:oardelean]]

I could reproduce this issue on a 2022-05-31 Nightly build on macOS 11 on Google Spreadsheets; verified as fixed on Firefox 102.0b5(20220607212916) and Nightly 103.0a1(20220608214824) on macOS 11, Windows 10 x64 and Ubuntu 20.04