1772216 - Add telemetry probe to measure how much time we spent waiting on the GPU

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Bas Schouten (:bas.schouten)]

When presenting a new frame we block the render frame on the GPU to have finished executing past GPU commands. We should measure how much time we spend doing this.

https://searchfox.org/mozilla-central/rev/1739f1301d658c9bff544a0a095ab11fca2e549d/gfx/webrender_bindings/RenderThread.cpp#567

Comment 1

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1772216: Add telemetry probe to measure time spent waiting for the GPU. r=mstange

Comment 2

[Bas Schouten (:bas.schouten)]

Attachment: gpuwait-datareview

Comment 3

[Chris H-C :chutten]

Comment on attachment 9279342 [details]
gpuwait-datareview

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, :Bas and gfx-telemetry-alerts are responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94fa038eea8e
Add telemetry probe to measure time spent waiting for the GPU. r=mstange

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing webrender build bustages

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f72a3e1b8a8d
Add telemetry probe to measure time spent waiting for the GPU. r=mstange

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f72a3e1b8a8d