Closed Bug 1772344 Opened 2 years ago Closed 2 years ago

browser_firefoxview_tab.js should wait for `BrowserTestUtils.waitForSessionStoreUpdate` after removing tab

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: farre, Assigned: farre)

References

Details

Attachments

(1 file)

Bug 1772344 - Wait for session store update after closing tab. r=dao!
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → afarre
Status: NEW → ASSIGNED
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/449e4b4fae71
Wait for session store update after closing tab. r=Gijs

Backed out for causing mochitest failures on browser_recently_closed_tabs.js

Failure line: browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js | first list item in recently-closed-tabs-list is in the correct order -

Push with failures

Failure log

Backout link

[task 2022-06-14T13:20:15.483Z] 13:20:15     INFO - TEST-START | browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js
[task 2022-06-14T13:20:15.491Z] 13:20:15     INFO - GECKO(6512) | [Parent 6512, GMPThread] WARNING: Failed to delete GMP storage directory: file /builds/worker/checkouts/gecko/dom/media/gmp/GMPServiceParent.cpp:1754
[task 2022-06-14T13:20:15.503Z] 13:20:15     INFO - GECKO(6512) | [Parent 6512: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fb948e17000 == 15 [pid = 6512] [id = 14]
[task 2022-06-14T13:20:15.503Z] 13:20:15     INFO - GECKO(6512) | [Parent 6512: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 38 (7fb9515a42b0) [pid = 6512] [serial = 38] [outer = 0]
[task 2022-06-14T13:20:15.506Z] 13:20:15     INFO - GECKO(6512) | [Parent 6512: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 39 (7fb948e21400) [pid = 6512] [serial = 39] [outer = 7fb9515a42b0]
[task 2022-06-14T13:20:15.519Z] 13:20:15     INFO - GECKO(6512) | [Child 6638, Main Thread] WARNING: '!CanHandleWith(aPresContext)', file /builds/worker/checkouts/gecko/dom/events/IMEStateManager.cpp:498
[task 2022-06-14T13:20:15.576Z] 13:20:15     INFO - GECKO(6512) | [Parent 6512: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 40 (7fb94e9fcc00) [pid = 6512] [serial = 40] [outer = 7fb9515a42b0]
[task 2022-06-14T13:20:15.596Z] 13:20:15     INFO - GECKO(6512) | [Parent 6512, Main Thread] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /builds/worker/checkouts/gecko/parser/html/nsHtml5StreamParser.cpp:1234
[task 2022-06-14T13:20:15.866Z] 13:20:15     INFO - GECKO(6512) | [Child 6736: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f4359b26400 == 1 [pid = 6736] [id = 0]
<...>
[task 2022-06-14T13:20:20.498Z] 13:20:20     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "http://mochi.test:8888/browser/" line: 0}]
[task 2022-06-14T13:20:20.499Z] 13:20:20     INFO - Buffered messages logged at 13:20:18
[task 2022-06-14T13:20:20.499Z] 13:20:20     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "http://www.example.com/" line: 0}]
[task 2022-06-14T13:20:20.502Z] 13:20:20     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "http://example.net/" line: 0}]
[task 2022-06-14T13:20:20.503Z] 13:20:20     INFO - Buffered messages logged at 13:20:19
[task 2022-06-14T13:20:20.506Z] 13:20:20     INFO - TEST-PASS | browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js | recently-closed-tabs-list should have one list item - 
[task 2022-06-14T13:20:20.507Z] 13:20:20     INFO - Buffered messages finished
[task 2022-06-14T13:20:20.508Z] 13:20:20     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js | first list item in recently-closed-tabs-list is in the correct order - 
[task 2022-06-14T13:20:20.508Z] 13:20:20     INFO - Stack trace:
[task 2022-06-14T13:20:20.508Z] 13:20:20     INFO - chrome://mochikit/content/browser-test.js:test_ok:1401
[task 2022-06-14T13:20:20.508Z] 13:20:20     INFO - chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js:test_list_ordering/<:131
[task 2022-06-14T13:20:20.512Z] 13:20:20     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-06-14T13:20:20.514Z] 13:20:20     INFO - TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js | last list item in recently-closed-tabs-list is in the correct order - 
[task 2022-06-14T13:20:20.514Z] 13:20:20     INFO - Stack trace:
[task 2022-06-14T13:20:20.515Z] 13:20:20     INFO - chrome://mochikit/content/browser-test.js:test_ok:1401
[task 2022-06-14T13:20:20.515Z] 13:20:20     INFO - chrome://mochitests/content/browser/browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js:test_list_ordering/<:138
[task 2022-06-14T13:20:20.516Z] 13:20:20     INFO - GECKO(6512) | [Child 6774, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_DoneGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:509
[task 2022-06-14T13:20:20.517Z] 13:20:20     INFO - GECKO(6512) | [Child 6774: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f4cb2c33000 == 0 [pid = 6774] [id = 0] [url = http://www.example.com/]
[task 2022-06-14T13:20:20.520Z] 13:20:20     INFO - GECKO(6512) | [Parent 6512, Main Thread] WARNING: ContentParent: id=7fb954085300 | BlockShutdown: ShutDownProcess: Closing channel.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1838
[task 2022-06-14T13:20:20.521Z] 13:20:20     INFO - GECKO(6512) | [Parent 6512, Main Thread] WARNING: ContentParent: id=7fb954085300 | BlockShutdown: ShutDownProcess: Close already called.: file /builds/worker/checkouts/gecko/dom/ipc/ContentParent.cpp:1845
[task 2022-06-14T13:20:20.521Z] 13:20:20     INFO - GECKO(6512) | [Child 6741, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_StartedGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:509
[task 2022-06-14T13:20:20.522Z] 13:20:20     INFO - GECKO(6512) | [Child 6774, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_StartedGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:509
[task 2022-06-14T13:20:20.525Z] 13:20:20     INFO - GECKO(6512) | [Child 6774, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_DoneGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:509
Flags: needinfo?(afarre)
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4741fb581a55
Wait for session store update after closing tab. r=Gijs
Flags: needinfo?(afarre)

https://hg.mozilla.org/mozilla-central/rev/4741fb581a55

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: