1772380 - Fix screen sharing failures resulting from the upstream import of libwebrtc c89fdd716c

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Changes in libwebrtc c89fdd716c have caused build and runtime failures in during screen sharing.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1772380 - Correct incorrectly named "unused" function pointer initialization;r?mjf

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1772380 - windows threading fixes;r?mjf

The underlying PlatformThread interface has changed. A stopped thread
can no longer be restarted. This seems like a step towards sanity.

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1772380 - to upstream - ref count this in lambda capture;r?mjf

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1772380 - additional non-windows threading fixes;r?mjf

Comment 5

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1772380 - Build xxx - (fix-c89fdd716c) fixes for the refactored PlatformThread API;r?mjf

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/966d30990cda
windows threading fixes;r?mjf
https://hg.mozilla.org/mozilla-central/rev/585ec9861006
Build 1766646 - (fix-c89fdd716c) fixes for the refactored PlatformThread API;r?mjf
https://hg.mozilla.org/mozilla-central/rev/6285ca3e1546
Correct incorrectly named "unused" function pointer initialization;r?mjf
https://hg.mozilla.org/mozilla-central/rev/7efcf976d7bf
additional non-windows threading fixes;r?mjf
https://hg.mozilla.org/mozilla-central/rev/0c4901eb3f96
to upstream - ref count this in lambda capture;r?mjf

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/966d30990cda
https://hg.mozilla.org/mozilla-central/rev/585ec9861006
https://hg.mozilla.org/mozilla-central/rev/6285ca3e1546
https://hg.mozilla.org/mozilla-central/rev/7efcf976d7bf
https://hg.mozilla.org/mozilla-central/rev/0c4901eb3f96