Closed Bug 1772636 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 34307 - Add a test that popups don't match :modal

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
103 Branch
Tracking Flags:
Tracking Status
firefox103 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34307 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34307
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Add a test that popups don't match :modal

Because :modal is still being added [1] to the codebase, this
test needs to check that it is supported. But once supported,
this will make sure popups are not "modal".

[1] https://chromium-review.googlesource.com/c/chromium/src/+/3655618

Bug: 1307772
Change-Id: I84e314761fe290858fe875ba24a8eff338f1e6f9
Reviewed-on: https://chromium-review.googlesource.com/3689361
WPT-Export-Revision: 7c75deded44fc24da040b1ab05e28f9cd923da86

PR 34307 applied with additional changes from upstream: 4f944e32b46acfc971af4ce345fc6b511aea59fe, 71cf6a42d3335c0c55cfe5b18c3b250c21a0ffbc
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 15 subtests

Status Summary

Firefox

OK : 1
FAIL: 15

Chrome

OK : 1
PASS: 14
FAIL: 1

Safari

OK : 1
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/popups/popup-attribute-basic.tentative.html [wpt.fyi]
    • The .showPopup() and .hidePopup() work on a popup, for <div popup="" id="boolean">Popup</div>.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() work on a popup, for <div popup="">Popup</div>.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() work on a popup, for <div popup="auto">Popup</div>.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() work on a popup, for <div popup="hint">Popup</div>.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() work on a popup, for <div popup="async">Popup</div>.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, <div>Non-popup</div>.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, <div popup="popup">Non-popup</div>.: FAIL (Chrome: PASS, Safari: FAIL)
    • The .showPopup() and .hidePopup() do NOT work on elements without a 'popup' attribute, <div popup="invalid">Non-popup</div>.: FAIL (Chrome: PASS, Safari: FAIL)
    • IDL attribute reflection: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popup attribute value should be case insensitive: FAIL (Chrome: PASS, Safari: FAIL)
    • Changing attribute values for popup should work: FAIL (Chrome: PASS, Safari: FAIL)
    • Changing attribute values should close open popups: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing a visible popup=auto element from the document should close the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing a visible popup=hint element from the document should close the popup: FAIL (Chrome: PASS, Safari: FAIL)
    • Removing a visible popup=async element from the document should close the popup: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d219769fb27e [wpt PR 34307] - Add a test that popups don't match :modal, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d219769fb27e

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox103: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.