1772655 - src/gl.cc:2841:17: runtime error: call to function mozilla::wr::WebRenderMallocSizeOf(void const*) through pointer to incorrect function type 'unsigned long (*)(void *)'

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Tyson Smith [:tsmith]]

I noticed this while running test in try. It's likely related to bug 1748880.

https://treeherder.mozilla.org/logviewer?job_id=380208811&repo=try&lineNumber=8116

src/gl.cc:2841:17: runtime error: call to function mozilla::wr::WebRenderMallocSizeOf(void const*) through pointer to incorrect function type 'unsigned long (*)(void *)'
/builds/worker/checkouts/gecko/gfx/webrender_bindings/WebRenderAPI.cpp:33: note: mozilla::wr::WebRenderMallocSizeOf(void const*) defined here
    #0 0x7fa1170774f5 in ReportMemory /builds/worker/checkouts/gecko/gfx/wr/swgl/src/gl.cc:2841:17
    #1 0x7fa1166992bf in swgl::swgl_fns::Context::report_memory::h45ca3fc4153aea02 /builds/worker/checkouts/gecko/gfx/wr/swgl/src/swgl_fns.rs:457:18
    #2 0x7fa1166992bf in webrender::device::gl::Device::report_memory::hc4a5a654877346d2 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/device/gl.rs:4042:28
    #3 0x7fa1166992bf in webrender::renderer::Renderer::report_memory::hc89e3873000ed5f9 /builds/worker/checkouts/gecko/gfx/wr/webrender/src/renderer/mod.rs:5590:19
    #4 0x7fa11678209d in wr_renderer_accumulate_memory_report /builds/worker/checkouts/gecko/gfx/webrender_bindings/src/bindings.rs:769:16
    #5 0x7fa107b076a7 in mozilla::wr::RendererOGL::AccumulateMemoryReport(mozilla::wr::MemoryReport*) /builds/worker/checkouts/gecko/gfx/webrender_bindings/RendererOGL.cpp:415:3
    #6 0x7fa107b07403 in mozilla::wr::RenderThread::DoAccumulateMemoryReport(mozilla::wr::MemoryReport, RefPtr<mozilla::MozPromise<mozilla::wr::MemoryReport, bool, true>::Private> const&) /builds/worker/checkouts/gecko/gfx/webrender_bindings/RenderThread.cpp:211:15
    #7 0x7fa107b23f4c in decltype(*(fp).*fp0(Get<0ul>(fp1).PassAsParameter(), Get<1ul>(fp1).PassAsParameter())) mozilla::detail::RunnableMethodArguments<mozilla::wr::MemoryReport, RefPtr<mozilla::MozPromise<mozilla::wr::MemoryReport, bool, true>::Private> >::applyImpl<mozilla::wr::RenderThread, void (mozilla::wr::RenderThread::*)(mozilla::wr::MemoryReport, RefPtr<mozilla::MozPromise<mozilla::wr::MemoryReport, bool, true>::Private> const&), StoreCopyPassByConstLRef<mozilla::wr::MemoryReport>, StoreRefPtrPassByPtr<mozilla::MozPromise<mozilla::wr::MemoryReport, bool, true>::Private>, 0ul, 1ul>(mozilla::wr::RenderThread*, void (mozilla::wr::RenderThread::*)(mozilla::wr::MemoryReport, RefPtr<mozilla::MozPromise<mozilla::wr::MemoryReport, bool, true>::Private> const&), mozilla::Tuple<StoreCopyPassByConstLRef<mozilla::wr::MemoryReport>, StoreRefPtrPassByPtr<mozilla::MozPromise<mozilla::wr::MemoryReport, bool, true>::Private> >&, std::integer_sequence<unsigned long, 0ul, 1ul>) /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1147:12
    #8 0x7fa107b23bab in apply<mozilla::wr::RenderThread, void (mozilla::wr::RenderThread::*)(mozilla::wr::MemoryReport, const RefPtr<mozilla::MozPromise<mozilla::wr::MemoryReport, bool, true>::Private> &)> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1153:12
    #9 0x7fa107b23bab in mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void (mozilla::wr::RenderThread::*)(mozilla::wr::MemoryReport, RefPtr<mozilla::MozPromise<mozilla::wr::MemoryReport, bool, true>::Private> const&), true, (mozilla::RunnableKind)0, mozilla::wr::MemoryReport, RefPtr<mozilla::MozPromise<mozilla::wr::MemoryReport, bool, true>::Private> >::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1200:13
    #10 0x7fa10535c2be in nsThread::ProcessNextEvent(bool, bool*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:1174:16
    #11 0x7fa105365f44 in NS_ProcessNextEvent(nsIThread*, bool) /builds/worker/checkouts/gecko/xpcom/threads/nsThreadUtils.cpp:465:10
    #12 0x7fa106948ea9 in mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) /builds/worker/checkouts/gecko/ipc/glue/MessagePump.cpp:330:5
    #13 0x7fa1067e57d1 in RunInternal /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:380:10
    #14 0x7fa1067e57d1 in RunHandler /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:373:3
    #15 0x7fa1067e57d1 in MessageLoop::Run() /builds/worker/checkouts/gecko/ipc/chromium/src/base/message_loop.cc:355:3
    #16 0x7fa105353877 in nsThread::ThreadFunc(void*) /builds/worker/checkouts/gecko/xpcom/threads/nsThread.cpp:378:10
    #17 0x7fa12d0dacde in _pt_root /builds/worker/checkouts/gecko/nsprpub/pr/src/pthreads/ptthread.c:201:5
    #18 0x7fa12ce0d6da in start_thread /tmp/glibc/nptl/pthread_create.c:463
    #19 0x7fa12bdeba3e in __clone /tmp/glibc/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1772655 - Fix ReportMemory in gl.cc to match the malloc_size_of signature. r=#gfx-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e01b3ddb8bbe
Fix ReportMemory in gl.cc to match the malloc_size_of signature. r=gfx-reviewers,jrmuizel

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e01b3ddb8bbe