1772693 - Unmaximized but not unfullscreened

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[vasdi]

Attachment: firefoxbug.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

Ubuntu 21.10
Gnome 42.1, X11
Firefox from snap, reproducible in Nightly build 20220604092742

With title bar hidden:
maximize Firefox window (by double-click on top bar)
set it full-screen (by pressing F11 key)
move cursor to the upper edge of the screen
double-click the bar

Actual results:

The window ends up in unexpected state. It behaves as fullscreen window but it's not one.

Expected results:

I expect window to stay maximized.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1772693 - Fix transition from fullscreen to maximized. r=stransky

We don't call MakeFullScreen(false), causing weirdness. This is needed even
with the next patch because otherwise other things like grabbing the tabbar
cause the same kind of weirdness.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1772693 - Don't transition from fullscreen -> maximized on double-click. r=stransky

It's probably unexpected (even though after the patch above it behaves
properly).

Depends on D148340

Comment 4

[Phabricator Automation]

Comment on attachment 9279753 [details]
Bug 1772693 - Fix transition from fullscreen to maximized. r=stransky

Revision D148340 was moved to bug 1773118. Setting attachment 9279753 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/844584297b2c
Don't transition from fullscreen -> maximized on double-click. r=stransky

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/844584297b2c

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on a 2022-06-04 Nightly build on Ubuntu 22.04 using the steps from the Description. Verified as fixed on Firefox 103.0b9(build ID: 20220714185732), Nightly 104.0a1(build ID: 20220717190235) and Nightly 104.0a1 Snap build(build ID: 20220718020349) on Ubuntu 22.04.