Closed Bug 1772726 Opened 4 years ago Closed 4 years ago

Remove osfile.jsm from services/sync

Categories

(Toolkit Graveyard :: OS.File, task)

Product:
Toolkit Graveyard
Component:
OS.File
Type:
task

Tracking

(firefox105 fixed)

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox105 --- fixed

People

(Reporter: beth, Assigned: beth)

References

Details

Attachments

(1 file)

Bug 1772726 - Port osfile.jsm usage to IOUtils in services/sync r?markh
48 bytes, text/x-phabricator-request
Details | Review
Blocks: 1737308
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e373fe2a3d3 Port osfile.jsm usage to IOUtils in services/sync r=markh

Backed out for causing failures on test_telemetry.js

[task 2022-06-17T21:15:05.584Z] 21:15:05     INFO -  TEST-START | services/sync/tests/unit/test_telemetry.js
[task 2022-06-17T21:15:07.250Z] 21:15:07  WARNING -  TEST-UNEXPECTED-FAIL | services/sync/tests/unit/test_telemetry.js | xpcshell return code: 0
[task 2022-06-17T21:15:07.251Z] 21:15:07     INFO -  TEST-INFO took 1666ms
[task 2022-06-17T21:15:07.252Z] 21:15:07     INFO -  >>>>>>>
[task 2022-06-17T21:15:07.253Z] 21:15:07     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2022-06-17T21:15:07.253Z] 21:15:07     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2022-06-17T21:15:07.254Z] 21:15:07     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2022-06-17T21:15:07.255Z] 21:15:07     INFO -  running event loop
[...............]
[task 2022-06-17T21:15:10.533Z] 21:15:10     INFO -  TEST-PASS | services/sync/tests/unit/test_telemetry.js | test_engine_fail_ioerror - [test_engine_fail_ioerror : 542] "error.sync.failed_partial" == "error.sync.failed_partial"
[task 2022-06-17T21:15:10.533Z] 21:15:10  WARNING -  TEST-UNEXPECTED-FAIL | services/sync/tests/unit/test_telemetry.js | test_engine_fail_ioerror - [test_engine_fail_ioerror : 545] "httperror" == "unexpectederror"
[task 2022-06-17T21:15:10.534Z] 21:15:10     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/services/sync/tests/unit/test_telemetry.js:test_engine_fail_ioerror/<:545
[task 2022-06-17T21:15:10.534Z] 21:15:10     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/services/sync/tests/unit/head_helpers.js:sync_and_validate_telem/telem.submit:413
[task 2022-06-17T21:15:10.534Z] 21:15:10     INFO -  resource://services-sync/telemetry.js:finish:772
[task 2022-06-17T21:15:10.535Z] 21:15:10     INFO -  resource://services-sync/telemetry.js:maybeSubmitForInterval:953
[task 2022-06-17T21:15:10.535Z] 21:15:10     INFO -  resource://services-sync/telemetry.js:takeTelemetryRecord:982
[task 2022-06-17T21:15:10.536Z] 21:15:10     INFO -  resource://services-sync/telemetry.js:onSyncFinished:967
[task 2022-06-17T21:15:10.536Z] 21:15:10     INFO -  resource://services-sync/telemetry.js:observe:1054
[task 2022-06-17T21:15:10.537Z] 21:15:10     INFO -  resource://services-common/observers.js:observe:135
[task 2022-06-17T21:15:10.537Z] 21:15:10     INFO -  resource://services-common/observers.js:notify:87
[task 2022-06-17T21:15:10.537Z] 21:15:10     INFO -  resource://services-sync/util.js:notify:195
[task 2022-06-17T21:15:10.538Z] 21:15:10     INFO -  resource://services-sync/util.js:WrappedNotify:202
[task 2022-06-17T21:15:10.538Z] 21:15:10     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_do_main:240
[task 2022-06-17T21:15:10.538Z] 21:15:10     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:597
[task 2022-06-17T21:15:10.539Z] 21:15:10     INFO -  -e:null:1
[task 2022-06-17T21:15:10.540Z] 21:15:10     INFO -  exiting test
Flags: needinfo?(brennie)
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b456d3e9ffe9 Port osfile.jsm usage to IOUtils in services/sync r=markh

Also this bug caused another failure, can you also please take a look at this before you reland? https://treeherder.mozilla.org/logviewer?job_id=384055557&repo=autoland

Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dd126cf14429 Port osfile.jsm usage to IOUtils in services/sync r=markh

https://hg.mozilla.org/mozilla-central/rev/dd126cf14429

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: