Closed Bug 1772847 Opened 2 years ago Closed 2 years ago

Enable devtools.responsive.showUserAgentInput on all channels?

Categories

(DevTools :: Framework, enhancement)

enhancement

Tracking

(firefox104 fixed)

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: tjr, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

While reviewing 2-year-old+ Nightly differences, I found devtools.responsive.showUserAgentInput which has been enabled on Nightly for a long time. Is it possible we can turn this on on all channels? (And if not, maybe we should remove it?)

Flags: needinfo?(jdescottes)

This was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1297431. I don't see any bug filed to enable that on all channels, but I also don't see a good reason not to do it.

The preference actually is linked to a setting, visible in the RDM menu "Show User agent". On all channels you can toggle this and it will update the preference, which will lead to show the User Agent in an input in the RDM UI.

So yes I think we can turn this on in all channels. If preferable we can also remove the preference from the file and handle the default value in our code?

Flags: needinfo?(jdescottes)

This preference drives the "Show user agent" feature accessible from the RDM options.
Flipping it to true will make the User agent input visible on all channels by default, but the feature itself was already available everywhere.
You just had to first select "Show user agent" in devedition/beta/release to show the input. I think the feature is useful enough to enable it by default.
Also we run all our tests with the preference forced to true.

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f37fd9ea18f7
[devtools] Enable devtools.responsive.showUserAgentInput on all channels r=devtools-reviewers,nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: