Closed Bug 1772851 Opened 2 years ago Closed 2 years ago

Fix devtools tests to not rely on ambient XUL

Categories

(DevTools :: General, task)

task

Tracking

(firefox103 fixed)

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

There are a handful of devtools tests that rely on XUL permissions being enabled by default:
devtools/client/inspector/markup/test/browser_markup_remove_xul_attributes.js
devtools/client/inspector/test/browser_inspector_highlighter-eyedropper-xul.js
devtools/client/inspector/rules/test/browser_rules_inactive_css_xul.js
devtools/server/tests/browser/browser_inspector-anonymous.js

We don't want to have to rely on XUL being enabled by default in tests, so I've written some patches to explicitly grant the relevant pages allowxulxbl permissions via SpecialPowers.pushPermissions.

There's another test which also needs a fix, which I've rolled into this patch because it is the same basic issue:

toolkit/components/tooltiptext/tests/browser_bug331772_xul_tooltiptext_in_html.js

Instead, explicitly add permissions for the domain that needs it.

Also browser_bug331772_xul_tooltiptext_in_html.js.

Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65e47e5dc7b5
Fix devtools tests to not rely on ambient XUL. r=devtools-reviewers,nchevobbe
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: