Closed Bug 1772894 Opened 2 months ago Closed 2 months ago

Only report GCs as full (non-zonal) if they are explicitly requested to be full

Categories

(Core :: JavaScript: GC, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

Currently the GC telemetry (gc_is_compartmental) will report a GC as full if 100% of zones are collected. One way for that to happen is for a full GC to be requested. Another way is for all zones to be scheduled for different reasons.

It looks like it would be more useful to base the definition off of the explicit request. For example, when tracking down why some change results in more full GCs, the happenstance full GCs are confusing—if I'm looking at a profile and seeing a bunch of full GCs, then I'll need to figure out whether they were requested to be full or happened to be full. Also, if there are a small number of Zones, then you'll be likely to see a higher percentage of full GCs by happenstance. (Which means for example that fission will increase the percentage of full GCs without any changes in scheduling logic.)

This is mostly an issue with telemetry and profile markers.

Assignee: nobody → sphink
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P1
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28628b207b56
Report noncompartmental aka nonzonal aka full GCs only when a full GC is requested, even if 100% of zones end up collecting r=jonco
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in before you can comment on or make changes to this bug.