Closed Bug 1772901 Opened 1 year ago Closed 1 year ago

Disable InstallTrigger implementation


(Toolkit :: Add-ons Manager, task, P2)




103 Branch
Tracking Status
firefox103 --- fixed


(Reporter: rpl, Assigned: rpl)


(Blocks 2 open bugs)


(Whiteboard: [addons-jira])


(1 file)

As a follow up of Bug 1754441, this bugzilla issue is tracking fully disabling the InstallTrigger implementation (by setting the about:config pref "extensions.InstallTriggerImpl.enabled" to false) in Nightly and let it ride the train to the other release channels.

The InstallTrigger global will still be enumerable (completely hiding the global is controlled by the separate about:config pref "extensions.InstallTrigger.enabled").

With the InstallTrigger global still enumerable but the InstallTrigger implementation disabled, null will be the value associated to the InstallTrigger global and it will still pass the typeof InstallTrigger !== "undefined" check often used user agent detection to recognize Firefox.

A separate bugzilla issue will track the followup of fully hiding the InstallTrigger global, because there are separate webcompat issues to consider due to the user agent detection use case.

See Also: → 1772905
Pushed by
Disable InstallTrigger methods. r=webcompat-reviewers,denschub,willdurand

Backed out for for causing failures on browser_dom_nodes_highlight.js

Backout link :

Push with failures:

Link to failure log:

Failure line:
TEST-UNEXPECTED-FAIL | devtools/client/dom/test/browser_dom_nodes_highlight.js | The correct node was highlighted - Got "h2", expected "h1"

Flags: needinfo?(lgreco)

I looked into the unexpected failure triggered in the apparently unrelated devtools DOM panel test, and I confirmed that it is:

  • due to an assumption in a couple of devtools DOM panel test case (which expects a certain number of rows by assuming that InstallTrigger is listed as a window global before the DOM nodes actually covered by the test, see Bug 1772905 comment 8)
  • those failures are triggered by Bug 1772905 and completely unrelated from the patch attached to this bug (which was merely part of the same push to autoland).

I'm going to push the patch attached to this bug on its own, and I've added a proposed tweak to the test case to Bug 1772905 (which I'll defer re-landing until the new patch has been reviewed and it is ready to land).

Flags: needinfo?(lgreco)
Pushed by
Disable InstallTrigger methods. r=webcompat-reviewers,denschub,willdurand
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Regressions: 1773873
See Also: → 1774005
Blocks: 1776426
You need to log in before you can comment on or make changes to this bug.