1772924 - Remove osfile.jsm usage from security/sandbox/

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, task, P3)

Description

[Beth Rennie [:beth] (she/her)]

https://searchfox.org/mozilla-central/search?q=osfile.jsm&path=^security%2Fsandbox%2F

Comment 1

[Beth Rennie [:beth] (she/her)]

Several functions in browser_content_sandbox_utils.js (e.g.) run OS.File in the child process. However, IOUtils is explicitly parent process only, so these will need to be migrated to use nsIFile & NetUtil or similar.

Comment 2

[Beth Rennie [:beth] (she/her)]

Since this is only exercising sandboxing, this can be ported to sync nsIFile methods.

Comment 3

[Beth Rennie [:beth] (she/her)]

This also requires creating symlinks.

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1772924 - Remove osfile.jsm usage in /security/sandbox/ r?jld,haik,bobowen

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on browser_content_sandbox_fs_xdg.js

• backout: https://hg.mozilla.org/integration/autoland/rev/f9108ee609e82380f8a6ca8365c2a5bcbca2f733
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=9a6e4fbe0be0095b2652ee08020cd0c822647d4d
• failure log: https://treeherder.mozilla.org/logviewer?job_id=399700126&repo=autoland&lineNumber=2455

[task 2022-12-15T03:15:45.333Z] 03:15:45     INFO - TEST-PASS | security/sandbox/test/browser_content_sandbox_fs_xdg.js | Temp file /tmp/.xdg_config_home_test/mozilla/.test_run_browser_sandbox.tmp was created - 
[task 2022-12-15T03:15:45.333Z] 03:15:45     INFO - Buffered messages finished
[task 2022-12-15T03:15:45.333Z] 03:15:45     INFO - TEST-UNEXPECTED-FAIL | security/sandbox/test/browser_content_sandbox_fs_xdg.js | Uncaught exception in test - Error: ChromeUtils.import is called against an ES module script (resource://gre/modules/FileUtils.sys.mjs).  Please use ChromeUtils.importESModule instead (SyntaxError: export declarations may only appear at top level of a module)
[task 2022-12-15T03:15:45.333Z] 03:15:45     INFO - Leaving test bound testFileAccessLinuxOnly
[task 2022-12-15T03:15:45.334Z] 03:15:45     INFO - Entering test bound cleanupBrowserTabs
[task 2022-12-15T03:15:45.335Z] 03:15:45     INFO - TEST-PASS | security/sandbox/test/browser_content_sandbox_fs_xdg.js | separate file content process is enabled - 

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa7b179af582
Remove osfile.jsm usage in /security/sandbox/ r=haik

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/aa7b179af582