1772956 - Only sync after tab change if the user has > 1 client

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Sammy Khamis [:skhamis]]

To help reduce the impact on the server for syncing after a tab change. We should only do this frequent sync if the user has greater than 1 client.

Comment 1

[Sammy Khamis [:skhamis]]

Attachment: Bug 1772956 - only sync after tab changes if the user has more than one client r=markh

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c21ba0b68a0c
only sync after tab changes if the user has more than one client r=markh

Comment 3

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/c21ba0b68a0c

Comment 4

[Sammy Khamis [:skhamis]]

Comment on attachment 9279973 [details]
Bug 1772956 - only sync after tab changes if the user has more than one client r=markh

Beta/Release Uplift Approval Request

• User impact if declined: This is an effort to reduce load on the server by only increasing sync frequency if a user have more than one device.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's not risky because it only targets sync users and the change is mainly adding an additional check to something wrapped around an experiment. Worst thing to happen is the experiment no longer works.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 5

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Sammy, c21ba0b68a0c does not graft cleanly to the beta branch, could you provide a patch for mozilla-beta? Thanks

Comment 6

[Sammy Khamis [:skhamis]]

Attachment: beta-tabs-1772956.patch

Sure thing, here is an updated patch with conflicts resolved. Thanks!

Comment 7

[Sammy Khamis [:skhamis]]

Try build for above patch: https://treeherder.mozilla.org/jobs?repo=try&revision=606e0f8e4db7496f79975fd6da2f23c55dd5159f

Comment 8

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9280354 [details] [diff] [review]
beta-tabs-1772956.patch

Approved for 102 beta 7, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until Sept 2)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a44113765f4d