1772976 - revisit how certificate error overrides from different contexts (e.g. private vs. non-private) interact

Status: RESOLVED FIXED

(Core :: Security: PSM, task, P1)

Description

[persmule]

Steps to reproduce:

Set up an HTTPS site with self-sign certificate.
Launch firefox.
Access the site from normal mode and add its certificate as a permanent certificate exception.
Open a private window.
Access the same site from the private window.

Actual results:

The warning for untrusted certificate is generated.
To suppress the warning, we should add the same certificate in the private window as a temporary certificate exception (because only temporary certificate exceptions can be added in private windows) over and over, when we access the site from a private window for the first time after we launch firefox.

Expected results:

We can access this site with no warning.
This used to happen in previous version.

Comment 1

[persmule]

This bug has been report to Debian as https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012430 .

At least, there should be an option (even in about:config) to control whether existing permanent certificate exceptions are effective in private windows, rather than rejecting them unconditionally.

Comment 2

[Andrew McCreight [:mccr8]]

Dana, any ideas on what to do with this bug? Thanks.

Comment 3

[Dana Keeler (she/her) [:keeler]]

This is currently expected behavior. Certificate error overrides are partitioned based on origin attributes, which includes the private browsing ID, if applicable. It's unclear what the "right" thing to do here is, as we do want some partitioning of overrides (e.g. if you add an override in a private context, non-private contexts shouldn't be affected by that). Perhaps we need to be more nuanced here, though.

Comment 4

[Dana Keeler (she/her) [:keeler]]

Attachment: Bug 1772976 - make non-private certificate error overrides available in private contexts r?jschanck

Certificate error overrides made in non-private contexts should be availble in
private contexts as well (but not vice-versa).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0e375a6c792
make non-private certificate error overrides available in private contexts r=jschanck

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c0e375a6c792