1773096 - Migrate browser.menu.showCharacterEncoding functionality away from nsIPrefLocalizedString

Status: RESOLVED FIXED

(Core :: Internationalization: Localization, task)

Description

[Tom Ritter [:tjr]]

This pref hasn't changed in a decade and it's unclear to me under what circumstances it changes...

Comment 1

[Gregory Pappas [:gregp]]

This pref controls whether or not the Repair Text Encoding button will be displayed by default. It's an important option for some locales but almost irrelevant to others, which is why this judgement is left to localizers.

So the functionality is necessary, but it'd be nice to move away from nsIPrefLocalizedString.

Comment 2

[Eemeli Aro [:eemeli]]

Attachment: Bug 1773096 - Remove browser.menu.showCharacterEncoding pref as unused. r?glandium!

Comment 3

[Eemeli Aro [:eemeli]]

Continuing here a conversation with :hsivonen that started on Phabricator.

The only place where we use browser.menu.showCharacterEncoding any more is here, migration code added in bug 1354117 and only relevant for users migrating onwards from Firefox 56 or earlier.

Henri also noted that bug 1702914 is tracking some of the follow-up work here, which (if it ever advances) would add the "Repair Text Encoding" action unconditionally to the "More Tools" hamburger submenu.

I'm going to update the patch to simply remove the pref as obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8c2dca895b8a
https://hg.mozilla.org/integration/autoland/rev/b4ad03056a5f
Remove browser.menu.showCharacterEncoding pref as unused. r=glandium,jdescottes,firefox-desktop-core-reviewers ,Gijs

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/b4ad03056a5f