1773200 - Update to wasi-sdk-16

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1773200 - Update to wasi-sdk-16.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74a8eb44e096
Update to wasi-sdk-16. r=firefox-build-system-reviewers,ahochheiden

Comment 3

[Atila Butkovits]

Backed out for causing bustages.

Backout link: https://hg.mozilla.org/integration/autoland/rev/97c5478005982ac7f268aa862acebc5e9199ace7

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=74a8eb44e0964cf69109a4771ca3eb752c310d63

Failure log: https://treeherder.mozilla.org/logviewer?job_id=380745449&repo=autoland&lineNumber=16271

Comment 4

[Jan Alexander Steffens [:heftig]]

It's a bulk memory.copy opcode. Arch Linux updated wasi-libc from 9886d3d to 30094b6 and ran into the same issue.

wasm2c doesn't support bulk memory ops yet, though there's a pull request at https://github.com/WebAssembly/wabt/pull/1877.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1773200 - Force-disable parts of wasi-libc built with -mbulk-memory.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d190451aa436
Force-disable parts of wasi-libc built with -mbulk-memory. r=firefox-build-system-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/4b5b77b114ad
Update to wasi-sdk-16. r=firefox-build-system-reviewers,ahochheiden

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d190451aa436
https://hg.mozilla.org/mozilla-central/rev/4b5b77b114ad

Comment 8

[Arthur K. (he/him)]

Just an FYI that there likely won't be a wasi-sdk-17 until this PR (https://github.com/WebAssembly/wasi-sdk/pull/255) gets fixed.

Comment 9

[Arthur K. (he/him)]

WASI SDK 17 just released: https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-17

Comment 10

[Arthur K. (he/him)]

FYI: WASI SDK 19 is now released: https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-19

• wasi-sdk-19

  Specify CMAKE_OSX_DEPLOYMENT_TARGET when building llvm (#285)
  Update llvm-project to the latest release/15.x (#286)
  Add README section for docker image (#282)

• wasi-sdk-18

  Build macOS universal binaries (#270)

  Update to the latest wasi-libc (#283)
  Don't use sbrk(0) to determine the initial heap size (WebAssembly/wasi-libc#377)
  Fix more headers to avoid depending on max_align_t (WebAssembly/wasi-libc#375)
  Use ENOENT rather than ENOTCAPABLE for missing preopens. (WebAssembly/wasi-libc#370)
  Adjust Makefile for LLVM trunk (16) as of 2022-11-08 (WebAssembly/wasi-libc#344)

NOTE: This release changes the behavior of malloc in programs compiled with -Wl,--initial-memory to use memory.grow rather than using all the statically-allocated memory. This will be fixed in wasi-sdk-19.

Comment 11

[Arthur K. (he/him)]

WASI SDK 20 is based on LLVM 16. https://github.com/WebAssembly/wasi-sdk/releases/tag/wasi-sdk-20

Is this worthwhile for inclusion in 115?