1773312 - Allow more characters in element/attribute names and prefixes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Domenic Denicola]

See spec changes at https://github.com/whatwg/dom/pull/1079 for:

• createAttribute()
• setAttribute()
• toggleAttribute()
• createElement()
• createElementNS()
• createDocument()
• createAttributeNS()
• setAttributeNS()

and https://github.com/whatwg/html/pull/7991 for updates to "valid custom element name" which impacts:

• customElements.define()
• customElements.whenDefined()
• Whether elements are HTMLElement or HTMLUnknownElement ( https://html.spec.whatwg.org/#elements-in-the-dom:valid-custom-element-name )

Comment 1

[Domenic Denicola]

We found one more instance, the dataset named property setter: https://github.com/whatwg/html/pull/11453

Comment 2

[sideshowbarker [:sideshowbarker]]

Attachment: Bug 1773312 - Allow more characters in element/attribute names and prefixes r=smaug,dom-core,devtools-reviewers,ochameau

Implement “relaxed” element/attribute name-validation rules, per:

• https://github.com/whatwg/dom/pull/1079
• https://github.com/whatwg/html/pull/7991
• https://github.com/whatwg/html/pull/11453

That aligns DOM-API name behavior with HTML parser behavior — which has
always allowed a wider range of characters in element and attribute names.

New validation functions in nsContentUtils:

• IsValidElementLocalName(): For createElement — allows [A-Za-z] start followed by
  any char except null/whitespace/>//, or [:_>=0x80] start with restricted continuation
• IsValidAttributeName(): For setAttribute/toggleAttribute/createAttribute —
  no null, whitespace, /, >, or =
• IsValidNamespacePrefix(): For *NS methods — no null, whitespace, /, or >
• IsValidDoctypeName(): For createDocumentType — no null, whitespace, or >
• ParseQualifiedNameRelaxed(): Validates and parses qualified names with relaxed rules

ParseQualifiedNameRelaxed() correctly implements the "strictly split" algorithm
per the DOM spec: for qualified names with multiple colons like "f:o:o", the
local name is just the second token ("o"), not everything after the first colon
("o:o"). This matches the spec's requirement to split on all colons and use only
splitResult[0] as prefix and splitResult[1] as localName.

Deleted outdated DOM Level 1 mochitest tests that tested old XML-based name
validation rules; WPT name-validation.html provides coverage for the new
relaxed rules. Removed WPT expected-failure .ini files, since all tests now pass.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3ae08e317eb9
https://hg.mozilla.org/integration/autoland/rev/4d11a13157d7
Allow more characters in element/attribute names and prefixes r=smaug,dom-core,devtools-reviewers,ochameau

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d11b8803574c
https://hg.mozilla.org/integration/autoland/rev/ffbf2e75d4f8
Revert "Bug 1773312 - Allow more characters in element/attribute names and prefixes r=smaug,dom-core,devtools-reviewers,ochameau" for causing failures at Document-createElement.html.

Comment 5

[Atila Butkovits]

Backed out for causing failures at Document-createElement.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/ffbf2e75d4f856f99b6bb4a9bc5a84d4dff9bf73

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4d11a13157d7c488bccca45c680e9e4318891c60&selectedTaskRun=UlscHA9eTBux0uE8C2X8tA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=543702555&repo=autoland&task=UlscHA9eTBux0uE8C2X8tA.0&lineNumber=23615

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/07632bbd30ee
https://hg.mozilla.org/integration/autoland/rev/060f0f5828e3
Allow more characters in element/attribute names and prefixes r=smaug,dom-core,devtools-reviewers,ochameau

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/11344a72b7d4
https://hg.mozilla.org/integration/autoland/rev/ddca65a8990f
Revert "Bug 1773312 - Allow more characters in element/attribute names and prefixes r=smaug,dom-core,devtools-reviewers,ochameau" for causing mochitest-plain failures on test_createAttributeNS03.html.

Comment 8

[Iulian Moraru]

Revert for causing mochitest-plain failures on test_createAttributeNS03.html.

• Push with failures

• Failure log

• Backout link

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e149aed5126a
https://hg.mozilla.org/integration/autoland/rev/06922ba5c6ce
Allow more characters in element/attribute names and prefixes r=smaug,dom-core,devtools-reviewers,ochameau

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/06922ba5c6ce

Comment 11

[Hamish Willee]

FF149 Docs work for this can be tracked in https://github.com/mdn/content/issues/43218