1773368 - Remove uses of JS::Handle/Rooted/etc typedefs for internal types (gc/Rooting.h)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

Remove uses with < 100 uses and leave JSObject/Value to another bug.

Comment 1

[Ted Campbell [:tcampbell]]

Note: Leave the deprecated typedefs until another bug

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs from js/src/debugger. r?iain

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs from JS modules code. r?iain

Depends on D148700

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs from JS SavedFrame code. r?iain

Depends on D148701

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/838ec2a94a22
Remove deprecated typedefs from js/src/debugger. r=iain
https://hg.mozilla.org/integration/autoland/rev/af783b4ad1a6
Remove deprecated typedefs from JS modules code. r=iain
https://hg.mozilla.org/integration/autoland/rev/1ed2417d19d7
Remove deprecated typedefs from JS SavedFrame code. r=iain

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/838ec2a94a22
https://hg.mozilla.org/mozilla-central/rev/af783b4ad1a6
https://hg.mozilla.org/mozilla-central/rev/1ed2417d19d7

Comment 7

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs for js::Shape. r?jandem

Comment 8

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs for js::Scope. r?jandem

Depends on D148816

Comment 9

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs for wasm objects. r?rhunt

Depends on D148817

Comment 10

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs for ScriptSourceObject. r?iain

Depends on D148818

Comment 11

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs for PlainObject. r?iain

Depends on D148819

Comment 12

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs for NativeObject. r?iain

Depends on D148820

Comment 13

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs for ArrayObject. r?iain

Depends on D148821

Comment 14

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated typedefs for GlobalObject. r?iain

Depends on D148822

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91a364b7b4d6
Remove deprecated typedefs for js::Shape. r=jandem
https://hg.mozilla.org/integration/autoland/rev/28a40cec06a4
Remove deprecated typedefs for js::Scope. r=jandem
https://hg.mozilla.org/integration/autoland/rev/bb9bbdfd0769
Remove deprecated typedefs for wasm objects. r=rhunt
https://hg.mozilla.org/integration/autoland/rev/c2c08d8943e2
Remove deprecated typedefs for ScriptSourceObject. r=iain
https://hg.mozilla.org/integration/autoland/rev/8c5004f69677
Remove deprecated typedefs for PlainObject. r=iain
https://hg.mozilla.org/integration/autoland/rev/57689fae2e5c
Remove deprecated typedefs for NativeObject. r=iain
https://hg.mozilla.org/integration/autoland/rev/518103b4bdc3
Remove deprecated typedefs for ArrayObject. r=iain
https://hg.mozilla.org/integration/autoland/rev/7006cd46385f
Remove deprecated typedefs for GlobalObject. r=iain

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/91a364b7b4d6
https://hg.mozilla.org/mozilla-central/rev/28a40cec06a4
https://hg.mozilla.org/mozilla-central/rev/bb9bbdfd0769
https://hg.mozilla.org/mozilla-central/rev/c2c08d8943e2
https://hg.mozilla.org/mozilla-central/rev/8c5004f69677
https://hg.mozilla.org/mozilla-central/rev/57689fae2e5c
https://hg.mozilla.org/mozilla-central/rev/518103b4bdc3
https://hg.mozilla.org/mozilla-central/rev/7006cd46385f

Comment 17

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove deprecated internal typedefs for string-related types. r?iain

Comment 18

[Ted Campbell [:tcampbell]]

Attachment: Bug 1773368 - Remove gc/Rooting.h r?jonco

The typedefs in this file were deprecated and have no more uses so remove the
file and add a few missing header dependencies.

Comment 19

[Ted Campbell [:tcampbell]]

I'll wrap this bug up with the removal of Rooting.h. A few of the Handle* variants are defined in other header files still but I didn't go looking for them in this bug.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d73e753cf2bb
Remove deprecated internal typedefs for string-related types. r=iain
https://hg.mozilla.org/integration/autoland/rev/70bde7b8be6a
Remove gc/Rooting.h r=jonco

Comment 21

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d73e753cf2bb
https://hg.mozilla.org/mozilla-central/rev/70bde7b8be6a