1773471 - Rename groupBy* to group*

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Yulia Startsev [:yulia]]

Per discussion at tc39, we will try this new name and see if it is any more compatible than groupBy.

Comment 1

[hemanth]

Attachment: Bug 1773471: Renaming to group and groupToMap r?yulia

Comment 2

[Hamish Willee]

Howdy, we recently created docs for Array.groupByToMap and Array.groupToMap and recorded support in FF Nightly.

1. Can you confirm this is a spec change and that the docs and compatibility should be changed to new names?
2. Is it just changed, or aliased - i.e. is the old name dead?
3. Do you think this is stable? i.e. is it worth just leaving as is for now because it could well change again.

As an aside, docs team don't follow specs as fast as dev teams. Adding a tag for docs required always appreciated.

Comment 3

[Yulia Startsev [:yulia]]

1. Can you confirm this is a spec change and that the docs and compatibility should be changed to new names?

This is a planned spec change due to naming collisions with groupBy in the sugar library (see https://bugzilla.mozilla.org/show_bug.cgi?id=1750812). We need to see if it is web compatible, and as we are currently the only browser with an implementation it sort of fell on us.

2. Is it just changed, or aliased - i.e. is the old name dead?

Name is changed, not aliased. If this works then groupBy is no longer going to be used.

3. Do you think this is stable? i.e. is it worth just leaving as is for now because it could well change again.

This is not stable. It is still stage 3 and we are testing to see if this new name will work.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e22fe4b498e
Renaming to group and groupToMap r=yulia

Comment 5

[Cristian Tuns]

Backed out for causing mochitest failures in test_xrayToJS.xhtml

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | A property on the Array prototype has changed! You need a security audit from an XPConnect peer - got "["at", "concat", "constructor", "copyWithin", "entries", "every", "fill", "filter", "find", "findIndex", "flat", "flatMap", "forEach", "group", "groupToMap", "includes", "indexOf", "join", "keys", "lastIndexOf", "length", "map", \

Comment 6

[hemanth]

Looks like I need to fix the failing test case, will work on it.

Comment 7

[Phabricator Automation]

Comment on attachment 9280437 [details]
Bug 1773471: Renaming to group and groupToMap r?yulia

Revision D148672 was moved to bug 1739648. Setting attachment 9280437 [details] to obsolete.

Comment 8

[hemanth]

Attachment: Bug 1773471: fixed test r?yulia

Depends on D148672

Comment 9

[hemanth]

Attachment: Bug 1773471: renamed test file r?yulia

Depends on D150471

Comment 10

[Phabricator Automation]

Comment on attachment 9280437 [details]
Bug 1773471: Renaming to group and groupToMap r?yulia

Revision D148672 was moved to bug 1739648. Setting attachment 9280437 [details] to obsolete.

Comment 11

[hemanth]

Attachment: Bug 1773471: renamed test file r?yulia

Depends on D150471

Comment 12

[hemanth]

❯ hg log
changeset:   695269:f96adebd3a6c
tag:         tip
user:        Hemanth HM <[e-mail]>
date:        Tue Jun 28 10:14:17 2022 -0700
summary:     Bug 1773471: renamed test file r?yulia

changeset:   695268:9558a0285900
bookmark:    central
parent:      692829:5e9018217ee1
user:        Hemanth HM <[e-mail]>
date:        Tue Jun 28 06:17:43 2022 -0700
summary:     Bug 1773471: fixed test r?yulia

I don't see three commits, hmm

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02293391dc47
fixed test r=yulia
https://hg.mozilla.org/integration/autoland/rev/9247e947c41c
renamed test file r=yulia

Comment 14

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/02293391dc47
https://hg.mozilla.org/mozilla-central/rev/9247e947c41c