Closed
Bug 1773535
Opened 2 years ago
Closed 2 years ago
Fix lint warnings in `TelemetrySend.jsm`
Categories
(Toolkit :: Telemetry, task, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
112 Branch
Tracking | Status | |
---|---|---|
firefox112 | --- | fixed |
People
(Reporter: nalexander, Assigned: beth)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidedi-ope])
Attachments
(1 file, 1 obsolete file)
In Bug 1770473, we ran into some lint warnings in TelemetrySend.jsm
:
$ ./mach lint toolkit/components/telemetry/app/TelemetrySend.jsm -W
error: problem with lint setup, skipping android-api-lint, android-checkstyle, android-format, android-javadoc, android-lint, android-test
.../toolkit/components/telemetry/app/TelemetrySend.jsm
233:22 warning Ci.nsIScriptableUnicodeConverter is deprecated. You should use TextEncoder or TextDecoder instead. mozilla/reject-scriptableunicodeconverter (eslint)
1036:24 warning OS.Path is deprecated. You should use PathUtils instead. mozilla/reject-osfile (eslint)
1342:22 warning Ci.nsIScriptableUnicodeConverter is deprecated. You should use TextEncoder or TextDecoder instead. mozilla/reject-scriptableunicodeconverter (eslint)
Updated•2 years ago
|
Comment 1•2 years ago
|
||
Replace usages of OS.Path
and Ci.nsIScriptableUnicodeConverter
.
Updated•2 years ago
|
Assignee: nobody → mathew.hodson
Status: NEW → ASSIGNED
Comment hidden (off-topic) |
Comment 3•2 years ago
|
||
Sorry, there was a problem with the detection of inactive users. I'm reverting the change.
Assignee: nobody → mathew.hodson
Status: NEW → ASSIGNED
Flags: needinfo?(chutten)
Assignee | ||
Updated•2 years ago
|
Assignee: mathew.hodson → brennie
Updated•2 years ago
|
Attachment #9280838 -
Attachment is obsolete: true
Assignee | ||
Comment 4•2 years ago
|
||
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e221ddc823c0
Remove usage of osfile.jsm and nsIScriptableUnicodeConverter from TelemetrySend.sys.mjs r=chutten
Comment 6•2 years ago
•
|
||
Backed out for causing multiple failures related to telemetry.
Flags: needinfo?(brennie)
Assignee | ||
Updated•2 years ago
|
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30ed0e6529a5
Remove usage of osfile.jsm and nsIScriptableUnicodeConverter from TelemetrySend.sys.mjs r=chutten
Comment 8•2 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•