1773694 - drag-and-drop from urlbar with forward slash in tab name creates directory

Status: RESOLVED DUPLICATE of bug 1774683

(Firefox :: Address Bar, defect, P2)

Description

[Bill]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

1. go to a web page with a forward-slash (/) in the page title (e.g. https://www.surrey.ac.uk/institute-communication-systems/5g-6g-innovation-centre with title "5G/6G Innovation Centre")
2. drag-and-drop the URL from the urlbar to a desktop folder

Actual results:

• a directory called "5G" was created in the desktop folder
• inside the "5G" directory, a link was created with the name "6G Innovation Centre" (the link contained that correct URL)

Expected results:

• no directory should have been created
• a link should have been created in the desktop folder with a filename derived from the page title
• some escaping of invalid filename characters (e.g. "/") should have been performed

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Marco Bonardo [:mak]]

P2 cause I'm not sure which consequences this may have (like building an appropriate name and convicing the user to drop the url into a specific path)... Though we'd still create a url file there.
It looks like we're missing filename sanitization here.
MIMEService has a new validateFileNameForSaving helper that we could likely use here.

Comment 3

[Marco Bonardo [:mak]]

This has been fixed by Bug 1774683