1773712 - Enable accelerated Canvas2D on macOS nightly

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1773712 - Enable accelerated Canvas2D on macOS nightly. r?jrmuizel

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c16ac03eca7
Enable accelerated Canvas2D on macOS nightly. r=jrmuizel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/767a824e1cc8
Fix license lint failure. a=lint-fix

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1773712 - Fix input-date-baseline-print.html meta filename. r?jrmuizel

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5c16ac03eca7
https://hg.mozilla.org/mozilla-central/rev/767a824e1cc8

Comment 6

[Cristian Tuns]

Backed out for causing crashes in Bug 1769254

• Backout link

Comment 7

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #2)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c16ac03eca7
Enable accelerated Canvas2D on macOS nightly. r=jrmuizel

== Change summary for alert #34439 (as of Mon, 13 Jun 2022 12:00:51 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
21%	google-docs SpeedIndex	macosx1015-64-shippable-qr	fission warm webrender	712.08 -> 861.67
17%	google-docs SpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	1,100.00 -> 1,291.00
6%	google-docs PerceptualSpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	1,318.38 -> 1,394.67
6%	google-docs FirstVisualChange	macosx1015-64-shippable-qr	cold fission webrender	720.00 -> 760.00
3%	google-docs ContentfulSpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	1,359.00 -> 1,398.17

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34439

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Cristian Tuns from comment #6)

Backed out for causing crashes in Bug 1769254

• Backout link

== Change summary for alert #34484 (as of Wed, 15 Jun 2022 00:16:06 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
18%	google-docs SpeedIndex	macosx1015-64-shippable-qr	fission warm webrender	862.17 -> 709.25
15%	google-docs SpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	1,291.42 -> 1,099.08
12%	google-docs loadtime	macosx1015-64-shippable-qr	cold fission webrender	920.67 -> 813.25
5%	google-docs PerceptualSpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	1,395.58 -> 1,320.08
5%	google-docs FirstVisualChange	macosx1015-64-shippable-qr	cold fission webrender	760.00 -> 720.00
3%	google-docs ContentfulSpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	1,399.83 -> 1,357.17

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34484

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07e7637819ec
Enable accelerated Canvas2D on macOS nightly. r=jrmuizel

Comment 10

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/07e7637819ec

Comment 11

[bszekely]

Backed out for causing reftest failures on 1304353-text-global-composite-op-1.html

Failure line: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/canvas/1304353-text-global-composite-op-1.html == layout/reftests/canvas/1304353-text-global-composite-op-1-ref.html | image comparison, max difference: 1, number of differing pixels: 34

Push with failures

Failure log

Backout link

Comment 12

[Norisz Fay [:noriszfay]]

Backout has been merged to central: https://hg.mozilla.org/mozilla-central/rev/50e29743ef21

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da8fba53f728
Enable accelerated Canvas2D on macOS nightly. r=jrmuizel

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/da8fba53f728

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Given the high crash rate in bug 1769254, I think we should probably back this change out for now.

Comment 16

[Lee Salzman [:lsalzman]]

I put in a stop-gap patch to reduce the crashiness in bug 1769254. We are actively investigating what's going on.