1773778 - Remove deprecated typedefs from gc/Barrier.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

The specialized typedefs for GCPtr/HeapPtr/etc types in gc/Barrier.h are deprecated and should be removed eventually.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 1: Remove unsued typedefs r?tcampbell

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 2: Remove deprecated PreBarrieredId typedef r?tcampbell

Depends on D149111

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 3: Remove deprecated PreBarrieredValue typedef r?tcampbell

Depends on D149112

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 4: Remove deprecated GCPtrAtom typedef r?tcampbell

Depends on D149113

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 5: Remove depreacted GCPtrFunction typedef r?tcampbell

Depends on D149114

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 6: Remove deprecated GCPtrLinearString typedef r?tcampbell

Depends on D149115

Comment 7

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 7: Remove deprecated GCPtrObject typedef r?tcampbell

Depends on D149116

Comment 8

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 8: Remove deprecated GCPtrValue typedef r?tcampbell

Depends on D149117

Comment 9

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 9: Remove deprecated ImmutablePropertyNamePtr typedef r?tcampbell

Depends on D149118

Comment 10

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 10: Remove deprecated ImmutableSymbolPtr typedef r?tcampbell

Depends on D149119

Comment 11

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 11: Remove deprecated WeakHeapPtrAtom typedef r?tcampbell

Depends on D149120

Comment 12

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 12: Remove deprecated WeakHeapPtrDebugEnvironmentProxy typedef r?tcampbell

Depends on D149121

Comment 13

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 13: Remove deprecated WeakHeapPtrJitCode typedef r?tcampbell

Depends on D149122

Comment 14

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 14: Remove deprecated WeakHeapPtrSymbol typedef r?tcampbell

Depends on D149123

Comment 15

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 15: Remove deprecated HeapPtrJitCode typedef r?tcampbell

Depends on D149124

Comment 16

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 16: Remove deprecated HeapPtrObject typedef r?tcampbell

Depends on D149125

Comment 17

[Jon Coppeard (:jonco)]

Attachment: Bug 1773778 - Part 17: Remove deprecated HeapPtrValue typedef r?tcampbell

Depends on D149126

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00a20c4add66
Part 1: Remove unsued typedefs r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e3c016c6d10c
Part 2: Remove deprecated PreBarrieredId typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/7c481f5d4790
Part 3: Remove deprecated PreBarrieredValue typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/de60b0087d84
Part 4: Remove deprecated GCPtrAtom typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a9f08ad1497f
Part 5: Remove depreacted GCPtrFunction typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/592fd3c8debb
Part 6: Remove deprecated GCPtrLinearString typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/eaa6af639ae0
Part 7: Remove deprecated GCPtrObject typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1c994fe58dc7
Part 8: Remove deprecated GCPtrValue typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/72a47bfe4e5c
Part 9: Remove deprecated ImmutablePropertyNamePtr typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b57c960a1823
Part 10: Remove deprecated ImmutableSymbolPtr typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9a70b30342a1
Part 11: Remove deprecated WeakHeapPtrAtom typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/67684221a8bb
Part 12: Remove deprecated WeakHeapPtrDebugEnvironmentProxy typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9b7a702f152e
Part 13: Remove deprecated WeakHeapPtrJitCode typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8850e9d9c962
Part 14: Remove deprecated WeakHeapPtrSymbol typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/07c65bc3ea1b
Part 15: Remove deprecated HeapPtrJitCode typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ab09f34fcbac
Part 16: Remove deprecated HeapPtrObject typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c52649447351
Part 17: Remove deprecated HeapPtrValue typedef r=tcampbell

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/00a20c4add66
https://hg.mozilla.org/mozilla-central/rev/e3c016c6d10c
https://hg.mozilla.org/mozilla-central/rev/7c481f5d4790
https://hg.mozilla.org/mozilla-central/rev/de60b0087d84
https://hg.mozilla.org/mozilla-central/rev/a9f08ad1497f
https://hg.mozilla.org/mozilla-central/rev/592fd3c8debb
https://hg.mozilla.org/mozilla-central/rev/eaa6af639ae0
https://hg.mozilla.org/mozilla-central/rev/1c994fe58dc7
https://hg.mozilla.org/mozilla-central/rev/72a47bfe4e5c
https://hg.mozilla.org/mozilla-central/rev/b57c960a1823
https://hg.mozilla.org/mozilla-central/rev/9a70b30342a1
https://hg.mozilla.org/mozilla-central/rev/67684221a8bb
https://hg.mozilla.org/mozilla-central/rev/9b7a702f152e
https://hg.mozilla.org/mozilla-central/rev/8850e9d9c962
https://hg.mozilla.org/mozilla-central/rev/07c65bc3ea1b
https://hg.mozilla.org/mozilla-central/rev/ab09f34fcbac
https://hg.mozilla.org/mozilla-central/rev/c52649447351

Comment 20

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #18)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00a20c4add66
Part 1: Remove unsued typedefs r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e3c016c6d10c
Part 2: Remove deprecated PreBarrieredId typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/7c481f5d4790
Part 3: Remove deprecated PreBarrieredValue typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/de60b0087d84
Part 4: Remove deprecated GCPtrAtom typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a9f08ad1497f
Part 5: Remove depreacted GCPtrFunction typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/592fd3c8debb
Part 6: Remove deprecated GCPtrLinearString typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/eaa6af639ae0
Part 7: Remove deprecated GCPtrObject typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1c994fe58dc7
Part 8: Remove deprecated GCPtrValue typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/72a47bfe4e5c
Part 9: Remove deprecated ImmutablePropertyNamePtr typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b57c960a1823
Part 10: Remove deprecated ImmutableSymbolPtr typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9a70b30342a1
Part 11: Remove deprecated WeakHeapPtrAtom typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/67684221a8bb
Part 12: Remove deprecated WeakHeapPtrDebugEnvironmentProxy typedef
r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9b7a702f152e
Part 13: Remove deprecated WeakHeapPtrJitCode typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8850e9d9c962
Part 14: Remove deprecated WeakHeapPtrSymbol typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/07c65bc3ea1b
Part 15: Remove deprecated HeapPtrJitCode typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ab09f34fcbac
Part 16: Remove deprecated HeapPtrObject typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c52649447351
Part 17: Remove deprecated HeapPtrValue typedef r=tcampbell

== Change summary for alert #34505 (as of Thu, 16 Jun 2022 03:11:45 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
12%	microsoft loadtime	windows10-64-shippable-qr	cold fission webrender	247.12 -> 277.00
8%	microsoft fcp	windows10-64-shippable-qr	cold fission webrender	226.19 -> 243.75

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34505

Comment 21

[Jon Coppeard (:jonco)]

These patches replaced use of typedefs with the underlying type and should not have caused any changes in generated code.