Remove deprecated typedefs from gc/Barrier.h
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: tcampbell, Assigned: jonco)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(17 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
The specialized typedefs for GCPtr/HeapPtr/etc types in gc/Barrier.h are deprecated and should be removed eventually.
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D149111
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D149112
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D149113
|
|
Assignee | |
Comment 5•3 years ago
|
||
Depends on D149114
|
|
Assignee | |
Comment 6•3 years ago
|
||
Depends on D149115
|
|
Assignee | |
Comment 7•3 years ago
|
||
Depends on D149116
|
|
Assignee | |
Comment 8•3 years ago
|
||
Depends on D149117
|
|
Assignee | |
Comment 9•3 years ago
|
||
Depends on D149118
|
|
Assignee | |
Comment 10•3 years ago
|
||
Depends on D149119
|
|
Assignee | |
Comment 11•3 years ago
|
||
Depends on D149120
|
|
Assignee | |
Comment 12•3 years ago
|
||
Depends on D149121
|
|
Assignee | |
Comment 13•3 years ago
|
||
Depends on D149122
|
|
Assignee | |
Comment 14•3 years ago
|
||
Depends on D149123
|
|
Assignee | |
Comment 15•3 years ago
|
||
Depends on D149124
|
|
Assignee | |
Comment 16•3 years ago
|
||
Depends on D149125
|
|
Assignee | |
Comment 17•3 years ago
|
||
Depends on D149126
|
||
Comment 18•3 years ago
|
||
|
||
Comment 19•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00a20c4add66
https://hg.mozilla.org/mozilla-central/rev/e3c016c6d10c
https://hg.mozilla.org/mozilla-central/rev/7c481f5d4790
https://hg.mozilla.org/mozilla-central/rev/de60b0087d84
https://hg.mozilla.org/mozilla-central/rev/a9f08ad1497f
https://hg.mozilla.org/mozilla-central/rev/592fd3c8debb
https://hg.mozilla.org/mozilla-central/rev/eaa6af639ae0
https://hg.mozilla.org/mozilla-central/rev/1c994fe58dc7
https://hg.mozilla.org/mozilla-central/rev/72a47bfe4e5c
https://hg.mozilla.org/mozilla-central/rev/b57c960a1823
https://hg.mozilla.org/mozilla-central/rev/9a70b30342a1
https://hg.mozilla.org/mozilla-central/rev/67684221a8bb
https://hg.mozilla.org/mozilla-central/rev/9b7a702f152e
https://hg.mozilla.org/mozilla-central/rev/8850e9d9c962
https://hg.mozilla.org/mozilla-central/rev/07c65bc3ea1b
https://hg.mozilla.org/mozilla-central/rev/ab09f34fcbac
https://hg.mozilla.org/mozilla-central/rev/c52649447351
|
||
Comment 20•3 years ago
|
||
(In reply to Pulsebot from comment #18)
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00a20c4add66
Part 1: Remove unsued typedefs r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/e3c016c6d10c
Part 2: Remove deprecated PreBarrieredId typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/7c481f5d4790
Part 3: Remove deprecated PreBarrieredValue typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/de60b0087d84
Part 4: Remove deprecated GCPtrAtom typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/a9f08ad1497f
Part 5: Remove depreacted GCPtrFunction typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/592fd3c8debb
Part 6: Remove deprecated GCPtrLinearString typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/eaa6af639ae0
Part 7: Remove deprecated GCPtrObject typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/1c994fe58dc7
Part 8: Remove deprecated GCPtrValue typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/72a47bfe4e5c
Part 9: Remove deprecated ImmutablePropertyNamePtr typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/b57c960a1823
Part 10: Remove deprecated ImmutableSymbolPtr typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9a70b30342a1
Part 11: Remove deprecated WeakHeapPtrAtom typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/67684221a8bb
Part 12: Remove deprecated WeakHeapPtrDebugEnvironmentProxy typedef
r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/9b7a702f152e
Part 13: Remove deprecated WeakHeapPtrJitCode typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8850e9d9c962
Part 14: Remove deprecated WeakHeapPtrSymbol typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/07c65bc3ea1b
Part 15: Remove deprecated HeapPtrJitCode typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ab09f34fcbac
Part 16: Remove deprecated HeapPtrObject typedef r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/c52649447351
Part 17: Remove deprecated HeapPtrValue typedef r=tcampbell
== Change summary for alert #34505 (as of Thu, 16 Jun 2022 03:11:45 GMT) ==
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 12% | microsoft loadtime | windows10-64-shippable-qr | cold fission webrender | 247.12 -> 277.00 |
| 8% | microsoft fcp | windows10-64-shippable-qr | cold fission webrender | 226.19 -> 243.75 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=34505
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 21•3 years ago
|
||
These patches replaced use of typedefs with the underlying type and should not have caused any changes in generated code.
Description
•