1773796 - Adaptive history autofill doesn't work with search strings that start with "www"

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

Adaptive history autofill doesn't seem to work with search strings that start with "www". With this adaptive history record:

url = https://www.nytimes.com/section/world
input = “www.nyt”

I can't trigger autofill for it by typing "www.nyt". I think it's because fixed_url_match will never be true in that case.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1773796: Corresponds to user's input that starts with www.

As pointed in the bug, the problem that can't find adaptive history by user's
input starts with "www." is in this query, since the fixup_url() removes not
only scheme but also "www.". In this bug case, we need to compare with string
removing scheme part only when user's input starts with "www.".
So, we introduce strip_scheme function that removes scheme only, then compare
with that's result.

In alternative idea, I thought we could use like following query.

"www." || fixup_url(h.url) COLLATE NOCASE BETWEEN :searchString
AND :searchString || X'FFFF' AS is_fixed_url_match

However, in this case, URLs that not start with "www." as well will be the
targets. As the user inputs "www." explicitly, that is, as I think that user
wants to find URL that starts "www.", did not choose this way.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ed95f9b6501
Corresponds to user's input that starts with www. r=adw

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/3ed95f9b6501

Comment 4

[Cristian Baica [:cbaica], Release Desktop QA]

Verified fixed on the latest Fx103.0a1 build. Adaptive autofill now works correctly for strings starting with 'www.'