1773797 - Convert all instance of do_CreateInstance for nsICryptoHash with NS_NewCryptoHash

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Barret Rennie [:barret] (they/them)]

Now that we have a C++ function to construct nsICryptoHash instances directly, we don't need to incur the run-time cost of calling do_CreateInstance("@mozilla.org/security/hash;1").

There are only a few usages:

	dom/media/gmp/CDMStorageIdProvider.cpp
37	do_CreateInstance("@mozilla.org/security/hash;1", &rv);
	dom/security/SRICheck.cpp
205	do_CreateInstance("@mozilla.org/security/hash;1", &rv);
	dom/security/nsCSPUtils.cpp
990	hasher = do_CreateInstance("@mozilla.org/security/hash;1", &rv);
	toolkit/components/reputationservice/ApplicationReputation.cpp
1297	do_CreateInstance("@mozilla.org/security/hash;1", &rv);

Comment 1

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1773797 - Replace do_CreateInstance for nsICryptoHash with NS_NewCryptoHash r?gijs!,nika!

Depends on D148965

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6471acf5208
Replace do_CreateInstance for nsICryptoHash with NS_NewCryptoHash r=Gijs,media-playback-reviewers,padenot,nika,ckerschb

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e6471acf5208