1773811 - Autoscroll does not scroll properly

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Alice0775 White]

Steps to reproduce:

1. Setting text bigger to other than 100% in Ease of Access of Windows settings.
2. Open any page that can be scrolled
3. Middle click to start autoscroll

Actual results:
Autoscroll does not scroll properly. Scroll with wrong direction.

Expected results:
Autoscroll scrolls properly

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cb7c4d0b946209a2a3b05cd5a35e31fadaf55135&tochange=6e1cbabce0af992a8ff5158959ac9dd69bea23a7

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1773342, could you take a look?
For more information, please visit auto_nag documentation.

Comment 2

[Fanolian]

On my Windows 10, Make text bigger has to be ≥105% in order to reproduce the bug.

1920x1080 monitor; display scaling 100%

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1773811 - Fix APZ autoscroll coordinates. r=botond,tnikkel

In bug 1773342, I made OS text zoom behave like layout full zoom on all
pages (including the main browser page).

This means that getting CSS pixels from the browser page and turning
them to LayoutDevice pixels by multiplying by GetDefaultScale() isn't
right.

However, the caller already has the right device pixel values, so just
use them.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/348eb31da96b
Fix APZ autoscroll coordinates. r=tnikkel

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/348eb31da96b

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on a 2022-06-11 Nightly build on Windows 10 64-bits; Verified as fixed on Firefox 103.0b6(build ID: 20220707185904) and Nightly 104.0a1(build ID: 20220707214915) on Windows 10 64-bits.