Closed
Bug 1773832
Opened 2 years ago
Closed 2 years ago
Refactor LoginManagerChild
Categories
(Toolkit :: Password Manager, task, P1)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
103 Branch
| Tracking | Status | |
|---|---|---|
| firefox103 | --- | fixed |
People
(Reporter: serg, Assigned: serg)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxcm-ios-parity])
Attachments
(18 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
- move more code from LoginManagerChild to LoginFormState
- #mark private members
- split mega-switch to dedicated function calls
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D148991
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D148992
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D148993
|
|
Assignee | |
Comment 5•2 years ago
|
||
Depends on D148994
|
|
Assignee | |
Comment 6•2 years ago
|
||
Depends on D148995
|
|
Assignee | |
Comment 7•2 years ago
|
||
Depends on D148996
|
|
Assignee | |
Comment 8•2 years ago
|
||
Depends on D148997
|
|
Assignee | |
Comment 9•2 years ago
|
||
Depends on D148998
|
|
Assignee | |
Comment 10•2 years ago
|
||
Depends on D148999
|
|
Assignee | |
Comment 11•2 years ago
|
||
Depends on D149000
|
|
Assignee | |
Comment 12•2 years ago
|
||
Depends on D149001
|
|
Assignee | |
Comment 13•2 years ago
|
||
Depends on D149002
|
|
Assignee | |
Comment 14•2 years ago
|
||
Depends on D149003
|
|
Assignee | |
Comment 15•2 years ago
|
||
Depends on D149004
|
|
Assignee | |
Comment 16•2 years ago
|
||
Depends on D149005
|
||
Updated•2 years ago
|
Assignee: nobody → sgalich
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 17•2 years ago
|
||
Depends on D149006
|
|
Assignee | |
Comment 18•2 years ago
|
||
Depends on D149007
|
|
||
Updated•2 years ago
|
Attachment #9280844 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: isProbablyAnEmailField r=dimi! → Bug 1773832 - Refactor LoginManagerChild: isProbablyAnEmailField r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280845 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: isProbablyAUsernameField r=dimi! → Bug 1773832 - Refactor LoginManagerChild: isProbablyAUsernameField r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280846 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: isProbablyAUsernameLoginForm r=dimi! → Bug 1773832 - Refactor LoginManagerChild: isProbablyAUsernameLoginForm r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280847 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _isLoginAlreadyFilled r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _isLoginAlreadyFilled r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280848 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _togglePasswordFieldMasking r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _togglePasswordFieldMasking r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280849 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _treatAsGeneratedPasswordField r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _treatAsGeneratedPasswordField r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280850 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _formHasModifiedFields r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _formHasModifiedFields r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280851 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _stopTreatingAsGeneratedPasswordField r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _stopTreatingAsGeneratedPasswordField r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280852 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: onFocus & #onUserNameFocus r=dimi! → Bug 1773832 - Refactor LoginManagerChild: onFocus & #onUserNameFocus r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280853 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _highlightFilledField r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _highlightFilledField r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280854 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: getUsernameFieldFromUsernameOnlyForm r=dimi! → Bug 1773832 - Refactor LoginManagerChild: getUsernameFieldFromUsernameOnlyForm r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280855 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _getPasswordFields r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _getPasswordFields r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280856 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _compareAndUpdatePreviouslySentValues r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _compareAndUpdatePreviouslySentValues r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280857 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _fillConfirmFieldWithGeneratedPassword r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _fillConfirmFieldWithGeneratedPassword r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280858 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: _getFormFields r=dimi! → Bug 1773832 - Refactor LoginManagerChild: _getFormFields r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280859 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: getUserNameAndPasswordFields r=dimi! → Bug 1773832 - Refactor LoginManagerChild: getUserNameAndPasswordFields r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280860 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: getFieldContext r=dimi! → Bug 1773832 - Refactor LoginManagerChild: getFieldContext r=dimi!
|
|
||
Updated•2 years ago
|
Attachment #9280861 -
Attachment description: WIP: Bug 1773832 - Refactor LoginManagerChild: #onUseGeneratedPassword r=dimi! → Bug 1773832 - Refactor LoginManagerChild: #onUseGeneratedPassword r=dimi!
|
|
Assignee | |
Updated•2 years ago
|
Severity: -- → N/A
Priority: -- → P1
|
||
Comment 19•2 years ago
|
||
Pushed by sgalich@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f8c996fae1d3
Refactor LoginManagerChild: isProbablyAnEmailField r=dimi
https://hg.mozilla.org/integration/autoland/rev/805b3a7e5740
Refactor LoginManagerChild: isProbablyAUsernameField r=dimi
https://hg.mozilla.org/integration/autoland/rev/6dfd353118e2
Refactor LoginManagerChild: isProbablyAUsernameLoginForm r=dimi
https://hg.mozilla.org/integration/autoland/rev/968562b082d6
Refactor LoginManagerChild: _isLoginAlreadyFilled r=dimi
https://hg.mozilla.org/integration/autoland/rev/47ad1e6a2a17
Refactor LoginManagerChild: _togglePasswordFieldMasking r=dimi
https://hg.mozilla.org/integration/autoland/rev/a44ec233a0b8
Refactor LoginManagerChild: _treatAsGeneratedPasswordField r=dimi
https://hg.mozilla.org/integration/autoland/rev/93c13f9f507d
Refactor LoginManagerChild: _formHasModifiedFields r=dimi
https://hg.mozilla.org/integration/autoland/rev/c0fd8377f368
Refactor LoginManagerChild: _stopTreatingAsGeneratedPasswordField r=dimi
https://hg.mozilla.org/integration/autoland/rev/45795b259daa
Refactor LoginManagerChild: onFocus & #onUserNameFocus r=dimi
https://hg.mozilla.org/integration/autoland/rev/74b5dcda1246
Refactor LoginManagerChild: _highlightFilledField r=dimi
https://hg.mozilla.org/integration/autoland/rev/21152bf61b4c
Refactor LoginManagerChild: getUsernameFieldFromUsernameOnlyForm r=dimi
https://hg.mozilla.org/integration/autoland/rev/d43e3c803e0d
Refactor LoginManagerChild: _getPasswordFields r=dimi
https://hg.mozilla.org/integration/autoland/rev/dbf1779b90b0
Refactor LoginManagerChild: _compareAndUpdatePreviouslySentValues r=dimi
https://hg.mozilla.org/integration/autoland/rev/421387e1ea53
Refactor LoginManagerChild: _fillConfirmFieldWithGeneratedPassword r=dimi
https://hg.mozilla.org/integration/autoland/rev/f51a497322f9
Refactor LoginManagerChild: _getFormFields r=dimi
https://hg.mozilla.org/integration/autoland/rev/06f49f624d16
Refactor LoginManagerChild: getUserNameAndPasswordFields r=dimi
https://hg.mozilla.org/integration/autoland/rev/227c71674f66
Refactor LoginManagerChild: getFieldContext r=dimi
https://hg.mozilla.org/integration/autoland/rev/1316552a367c
Refactor LoginManagerChild: #onUseGeneratedPassword r=dimi
|
||
Comment 20•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f8c996fae1d3
https://hg.mozilla.org/mozilla-central/rev/805b3a7e5740
https://hg.mozilla.org/mozilla-central/rev/6dfd353118e2
https://hg.mozilla.org/mozilla-central/rev/968562b082d6
https://hg.mozilla.org/mozilla-central/rev/47ad1e6a2a17
https://hg.mozilla.org/mozilla-central/rev/a44ec233a0b8
https://hg.mozilla.org/mozilla-central/rev/93c13f9f507d
https://hg.mozilla.org/mozilla-central/rev/c0fd8377f368
https://hg.mozilla.org/mozilla-central/rev/45795b259daa
https://hg.mozilla.org/mozilla-central/rev/74b5dcda1246
https://hg.mozilla.org/mozilla-central/rev/21152bf61b4c
https://hg.mozilla.org/mozilla-central/rev/d43e3c803e0d
https://hg.mozilla.org/mozilla-central/rev/dbf1779b90b0
https://hg.mozilla.org/mozilla-central/rev/421387e1ea53
https://hg.mozilla.org/mozilla-central/rev/f51a497322f9
https://hg.mozilla.org/mozilla-central/rev/06f49f624d16
https://hg.mozilla.org/mozilla-central/rev/227c71674f66
https://hg.mozilla.org/mozilla-central/rev/1316552a367c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
|
||
Updated•2 years ago
|
Whiteboard: [fxcm-ios-parity]
|
||
Updated•2 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•