1773906 - Remove osfile.jsm usage from toolkit/components/telemetry/tests/

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task)

Description

[Mathew Hodson]

https://searchfox.org/mozilla-central/search?q=osfile.jsm&path=%5Etoolkit%2Fcomponents%2Ftelemetry%2Ftests%2F

Comment 1

[Mathew Hodson]

Attachment: Bug 1773906 - Replace osfile.jsm usage in telemetry tests. r?chutten

This fixes the lint warnings in the modified files.
The only remaining use of osfile.jsm is for OS.Constants.Path.libxul,
which doesn't have an equivalent in PathUtils.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 3

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/328d4513c802
Replace osfile.jsm usage in telemetry tests. r=chutten

Comment 5

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing failures on test_TelemetrySession.js . CLOSED TREE
Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySession.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySession.js | test_abortedDailyCoalescing - [test_abortedDailyCoalescing : 1578] There must be an aborted session ping. - false == true

Comment 6

[Mathew Hodson]

The test passes on my Windows 10 computer with an artifact build. I use: .\mach test toolkit/components/telemetry/tests/unit/test_TelemetrySession.js

test_abortedDailyCoalescing is intermittent I guess. I see failures in the test-verify runs as well as the reported Windows 7 opt build.

Comment 7

[Chris H-C :chutten]

It could be intermittent, it'll take me a while to build on my win10 and find out (I've got to send my laptop in for repairs). The one that draws my attention is the test_PingSender.js failures on OSX which I can reproduce on Linux x64 opt.

Comment 8

[Mathew Hodson]

There's three places in this patch where I didn't update noOverwrite. I noticed now that this option was changed in IOUtils and the migration doc is outdated. I created bug 1818923 for that.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:barret, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80cacf030f1b
Replace osfile.jsm usage in telemetry tests. r=chutten

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/80cacf030f1b