1773932 - Remove `nsIScriptableUnicodeConverter` from services/common/utils.js

Status: RESOLVED FIXED

(Firefox :: Sync, task, P2)

Description

[Mathew Hodson]

utils.js uses nsIScriptableUnicodeConverter in some function like encodeUTF8. Callers should be moved to TextEncoder or IOUtils.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::OS.File' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Timea Zsoldos [:tzsoldos], Desktop QA]

Hi Barret,
Please set this as "New", as I see you forgot to do this, or am I wrong? Waiting for the developers opinion about it.
Thank you!

Comment 3

[Knot False]

Attachment: Bug 1773932 - Remove nsIScriptableUnicodeConverter from services/common/utils.sys.mjs. r=skhamis,markh

Comment 4

[Knot False]

Patch submitted: https://phabricator.services.mozilla.com/D275341. Ready for review

Comment 5

[Knot False]

(In reply to Knot False from comment #4)

Patch submitted: https://phabricator.services.mozilla.com/D275341. Ready for review

wrong tab; patch is https://phabricator.services.mozilla.com/D275352

Comment 6

[Knot False]

(In reply to Knot False from comment #4)

Patch submitted: https://phabricator.services.mozilla.com/D275341. Ready for review

wrong tab; patch is https://phabricator.services.mozilla.com/D275352

Comment 7

[Sammy Khamis [:skhamis]]

Thanks for putting up that patch Knot! Just bumping here incase the phab notification fell the the cracks...I had just one minor change and we can get this landed!

Comment 8

[BugBot [:suhaib / :marco]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:markh, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Sammy Khamis [:skhamis]]

Hi Knot, are you still working on this patch? It's nearly ready to land and would be great to get this in!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/83f36c7d77fc
https://hg.mozilla.org/integration/autoland/rev/5b8a71bc7eb2
Remove nsIScriptableUnicodeConverter from services/common/utils.sys.mjs. r=markh

Comment 11

[rperta]

https://hg.mozilla.org/mozilla-central/rev/5b8a71bc7eb2