1773971 - Use frame pointers in more places

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

I have a patch stack that fixes various places to take advantage of frame pointers. With these changes, we can also assert in JSJitFrameIter that the frame pointers match the frame descriptors.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1773971 part 1 - Use frame pointer instead of frame descriptor to restore SP for apply calls. r?iain!

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1773971 part 2 - Restore frame pointer before FinishBailoutToBaseline call. r?iain!

This ensures we'll store the correct frame pointer in the exit frame for the
FinishBailoutToBaseline call with later patches.

Depends on D149058

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1773971 part 3 - Use frame pointer after calls to Bailout and InvalidationBailout. r?iain!

This is simpler and also ensures we have the correct frame pointer value for the exception
path in the bailout tail code.

Depends on D149059

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1773971 part 4 - Add frame pointer to exit frames. r?iain!

Now all frames have the saved frame pointer.

Depends on D149060

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1773971 part 5 - Ensure Wasm exit frames have the correct frame pointer value. r?iain!

Depends on D149061

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1773971 part 6 - Use frame pointer instead of frame descriptor in EnterJit trampoline. r?iain!

Fix the exception handler to restore the frame pointer for this case too,
then in EnterJit use the frame pointer to restore the stack pointer.

Depends on D149062

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1773971 part 7 - Assert frame pointers match frame descriptors. r?iain!

Depends on D149063

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d32dfc7ad4a
part 1 - Use frame pointer instead of frame descriptor to restore SP for apply calls. r=iain
https://hg.mozilla.org/integration/autoland/rev/a64867189f7a
part 2 - Restore frame pointer before FinishBailoutToBaseline call. r=iain
https://hg.mozilla.org/integration/autoland/rev/1c86926688dd
part 3 - Use frame pointer after calls to Bailout and InvalidationBailout. r=iain
https://hg.mozilla.org/integration/autoland/rev/a0a1431a88e8
part 4 - Add frame pointer to exit frames. r=iain
https://hg.mozilla.org/integration/autoland/rev/599b71051df9
part 5 - Ensure Wasm exit frames have the correct frame pointer value. r=iain
https://hg.mozilla.org/integration/autoland/rev/bffd69d47ed4
part 6 - Use frame pointer instead of frame descriptor in EnterJit trampoline. r=iain
https://hg.mozilla.org/integration/autoland/rev/747c5d43a388
part 7 - Assert frame pointers match frame descriptors. r=iain

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4d32dfc7ad4a
https://hg.mozilla.org/mozilla-central/rev/a64867189f7a
https://hg.mozilla.org/mozilla-central/rev/1c86926688dd
https://hg.mozilla.org/mozilla-central/rev/a0a1431a88e8
https://hg.mozilla.org/mozilla-central/rev/599b71051df9
https://hg.mozilla.org/mozilla-central/rev/bffd69d47ed4
https://hg.mozilla.org/mozilla-central/rev/747c5d43a388