1773997 - Add tests for loading import maps with <base> element

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

See https://github.com/WICG/import-maps#base-element
If there's a <base> element, it will change the base URI of the document, which will also change the baseURL in import maps.
So we should have some tests to make sure import maps behaves correctly with the <base> element.
Also, the test could be used to test the speculative parsing of import maps in Bug 1762595

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Bug 1773997 - Part 1: Add mochitests for loading import maps with <base> element.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Bug 1773997 - Part 2: Use absolute path when calling static_import.py

With the <base> element, the relative path will be changed, therefore
modifying the script.src to use absolute paths if it's using relative path.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Bug 1773997 - Part 3: wpt with <base> for import-maps.

With <base> element changes the base URL to "./resources/", the baseURL
of the import map should be updated as well.
The url "log.js" in the import map will be resolved to "./resources/log.js".

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb.7]

Attachment: Bug 1773997 - Part 4: wpt for injecting a <base> element for import-maps.

Add a helper function called testInIframeInjectBase, which will include
a Javascript file, which will in turn inject a <base> element into current
document.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c39a082c94b
Part 1: Add mochitests for loading import maps with <base> element. r=jonco
https://hg.mozilla.org/integration/autoland/rev/7754a95427ef
Part 2: Use absolute path when calling static_import.py r=jonco,yulia
https://hg.mozilla.org/integration/autoland/rev/968815f882d2
Part 3: wpt with <base> for import-maps. r=jonco,yulia
https://hg.mozilla.org/integration/autoland/rev/12620b755d6b
Part 4: wpt for injecting a <base> element for import-maps. r=jonco,yulia

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35235 for changes under testing/web-platform/tests

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4c39a082c94b
https://hg.mozilla.org/mozilla-central/rev/7754a95427ef
https://hg.mozilla.org/mozilla-central/rev/968815f882d2
https://hg.mozilla.org/mozilla-central/rev/12620b755d6b

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot