Closed Bug 177400 Opened 22 years ago Closed 22 years ago

[FIX]ldap array cleanup/leak fixes

Categories

(Directory :: LDAP XPCOM SDK, defect)

Product:
Directory
Component:
LDAP XPCOM SDK
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

voila
7.68 KB, patch
dmosedale
: review+
alecf
: superreview+
Details | Diff | Splinter Review 
The usual... some nsCOMArray stuff, some already_AddRefed stuff. THe leak was in
the loop that called PopListener without releasing the pointers....
Attached patch voila — — Splinter Review 

    
  

        Attachment #104579 -
        Flags: review?(dmose)

    
  
Summary: ldap array cleanup/leak fixes → [FIX]ldap array cleanup/leak fixes

    
    

    
  
Comment on attachment 104579 [details] [diff] [review]
voila

r=dmose

        Attachment #104579 -
        Flags: review?(dmose) → review+

    
  

        Attachment #104579 -
        Flags: superreview?(alecf)

    
    

    
  
Comment on attachment 104579 [details] [diff] [review]
voila

sr=alecf
nice use of already_AddRefed

        Attachment #104579 -
        Flags: superreview?(alecf) → superreview+

    
    

    
  
danke.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: