1774125 - Crash in [@ core::option::expect_failed | neqo_transport::connection::Connection::handle_ack<T>]

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Takanori MATSUURA]

Crash report: https://crash-stats.mozilla.org/report/index/373928d6-424f-4087-94cc-3a9de0220614

Reason: EXCEPTION_BREAKPOINT

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:17
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:91
2 xul.dll core::ops::function::Fn::call<void  ../fe5b13d681f25ee6474be29d748c65adcd91f69e/library/core/src/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook ../fe5b13d681f25ee6474be29d748c65adcd91f69e//library/std/src/panicking.rs:702
4 xul.dll std::panicking::begin_panic_handler::closure$0 ../fe5b13d681f25ee6474be29d748c65adcd91f69e//library/std/src/panicking.rs:588
5 xul.dll std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure_env$0, never$> ../fe5b13d681f25ee6474be29d748c65adcd91f69e//library/std/src/sys_common/backtrace.rs:138
6 xul.dll std::panicking::begin_panic_handler ../fe5b13d681f25ee6474be29d748c65adcd91f69e//library/std/src/panicking.rs:584
7 xul.dll core::panicking::panic_fmt ../fe5b13d681f25ee6474be29d748c65adcd91f69e//library/core/src/panicking.rs:143
8 xul.dll core::panicking::panic_display<str> ../fe5b13d681f25ee6474be29d748c65adcd91f69e//library/core/src/panicking.rs:72
9 xul.dll core::panicking::panic_str ../fe5b13d681f25ee6474be29d748c65adcd91f69e//library/core/src/panicking.rs:56

Comment 1

[Takanori MATSUURA]

This is startup crash and priority P1.

Comment 2

[Takanori MATSUURA]

Regressed by bug 1772092?

Comment 3

[Andrew McCreight [:mccr8]]

This looks like a crash in Necko's Rust code. The crash reason for most of these crashes (such as bp-08c09b03-2594-4a3b-8cef-ebfbd0220614) is "ACK on discarded space".

Comment 4

[.]

Can reproduce on Arch x86_64 and Debian i386. I filed bug 1774113 a bit ago which can probably be merged with this one.

This issue only appears to be a startup crash b/c a webpage tapping into the new neqo code is loaded at browser start.

Keep me posted.

Comment 6

[Andrew McCreight [:mccr8]]

Per the bisection in bug 1774113, this is a regression from bug 1772092.

Comment 8

[BugBot [:suhaib / :marco]]

Copying crash signatures from duplicate bugs.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1772092 got backed out, new Nightly builds have been requested.

Comment 10

[Dragana Damjanovic [:dragana]]

This has been fixed in the newest neqo update.