1774169 - Tab Pickup - add observer, keyboard navigation and tests

Status: RESOLVED FIXED

(Firefox :: General, task)

Comment 1

[Sarah Clements [:sclements]]

Attachment: Bug 1774169 - Add observer, keyboard nav & tests to Tab Pickup list r=Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2426eb39bdb7
Add observer, keyboard nav & tests to Tab Pickup list r=Gijs

Comment 3

[Cristian Tuns]

Backed out for causing mochitest failures on browser_newtab_userTypedValue.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_newtab_userTypedValue.js | leaked 2 window(s) until shutdown [url = about:firefoxview]

Comment 4

[Sarah Clements [:sclements]]

I'm not seeing how my patch is the cause of this crash. :Gijs, would you mind taking a look?

Comment 5

[:Gijs (he/him)]

(In reply to Sarah Clements [:sclements] from comment #4)

I'm not seeing how my patch is the cause of this crash. :Gijs, would you mind taking a look?

It's not a crash, just a leak, I think?

browser/components/sessionstore/test/browser_newtab_userTypedValue.js will open about:firefoxview in a tab and close it pretty quickly. If I had to guess then the observer you added or something else is causing a reference to be held to the Firefox View content window, which is causing it to leak. So the first thing I'd do is get a debug artifact build locally, run just that test, and see if you can reproduce. If so, add logging to the code adding and removing the observer, and see if both of them are called. Does that help?

Comment 6

[Sarah Clements [:sclements]]

Yes, I figured it out - thanks for the tip.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67284b4484e5
Add observer, keyboard nav & tests to Tab Pickup list r=Gijs

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/67284b4484e5