Tab Pickup - add observer, keyboard navigation and tests
Categories
(Firefox :: General, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox103 | --- | fixed |
People
(Reporter: sclements, Assigned: sclements)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-2022-mr1-firefox-view])
Attachments
(1 file)
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Updated•2 years ago
|
Pushed by sclements@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2426eb39bdb7 Add observer, keyboard nav & tests to Tab Pickup list r=Gijs
Comment 3•2 years ago
|
||
Backed out for causing mochitest failures on browser_newtab_userTypedValue.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_newtab_userTypedValue.js | leaked 2 window(s) until shutdown [url = about:firefoxview]
Assignee | ||
Comment 4•2 years ago
|
||
I'm not seeing how my patch is the cause of this crash. :Gijs, would you mind taking a look?
Comment 5•2 years ago
|
||
(In reply to Sarah Clements [:sclements] from comment #4)
I'm not seeing how my patch is the cause of this crash. :Gijs, would you mind taking a look?
It's not a crash, just a leak, I think?
browser/components/sessionstore/test/browser_newtab_userTypedValue.js
will open about:firefoxview
in a tab and close it pretty quickly. If I had to guess then the observer you added or something else is causing a reference to be held to the Firefox View content window, which is causing it to leak. So the first thing I'd do is get a debug artifact build locally, run just that test, and see if you can reproduce. If so, add logging to the code adding and removing the observer, and see if both of them are called. Does that help?
Assignee | ||
Comment 6•2 years ago
|
||
Yes, I figured it out - thanks for the tip.
Pushed by sclements@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67284b4484e5 Add observer, keyboard nav & tests to Tab Pickup list r=Gijs
Comment 8•2 years ago
|
||
bugherder |
Description
•