1774175 - Call SetAcquiringImportMaps(false) when fetching a modulepreload module script graph

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb. 3]

From the import maps spec
https://wicg.github.io/import-maps/#wait-for-import-maps

When the browser starts to fetch a modulepreload module script graph 1, it should call set acquiring import maps to false 2

Currently Gecko doesn't support <link rel="modulepreload"> yet (bug 1425310)
But the WPT for Import Maps will test this behavior. modulepreload.html 3, and modulepreload-link-header.html 4

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb. 3]

I have a patch that doesn't actually do the module preloading, but it will call SetAcquiringImportMaps(false) if it found any <link rel="modulepreload> element or a HTTP header with Link <...> rel=modulepreload

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb. 3]

Attachment: Bug 1774175 - Call SetAcquiringImportMaps(false) when processing modulepreload.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb. 3]

Hi Jonco and Yulia
Do you think we could land the short fix first without actually implementing modulepreload feature?

Comment 4

[Yulia Startsev [:yulia]]

Yes, we can land this without implementing modulepreload yet.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi] OOO ~ Feb. 3]

Jonco says he's also fine with this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/110862c2c4da
Call SetAcquiringImportMaps(false) when processing modulepreload. r=yulia,smaug

Comment 7

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/110862c2c4da