Closed Bug 1774175 Opened 4 months ago Closed 3 months ago

Call SetAcquiringImportMaps(false) when fetching a modulepreload module script graph

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
104 Branch
Tracking Status
firefox104 --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

From the import maps spec
https://wicg.github.io/import-maps/#wait-for-import-maps

When the browser starts to fetch a modulepreload module script graph 1, it should call set acquiring import maps to false 2

Currently Gecko doesn't support <link rel="modulepreload"> yet (bug 1425310)
But the WPT for Import Maps will test this behavior. modulepreload.html 3, and modulepreload-link-header.html 4

I have a patch that doesn't actually do the module preloading, but it will call SetAcquiringImportMaps(false) if it found any <link rel="modulepreload> element or a HTTP header with Link <...> rel=modulepreload

Hi Jonco and Yulia
Do you think we could land the short fix first without actually implementing modulepreload feature?

Flags: needinfo?(ystartsev)
Flags: needinfo?(jcoppeard)

Yes, we can land this without implementing modulepreload yet.

Flags: needinfo?(ystartsev)

Jonco says he's also fine with this.

Flags: needinfo?(jcoppeard)
Assignee: nobody → allstars.chh
Attachment #9281386 - Attachment description: Bug 1774175 - Call SetAcquiringImportMaps(false) for modulepreload. → Bug 1774175 - Call SetAcquiringImportMaps(false) when processing modulepreload.
Pushed by allstars.chh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/110862c2c4da
Call SetAcquiringImportMaps(false) when processing modulepreload. r=yulia,smaug
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 104 Branch
Depends on: 1777496
Blocks: js-lang
You need to log in before you can comment on or make changes to this bug.