1774217 - support comments in auth tokens

Status: RESOLVED FIXED

(Tecken :: General, enhancement, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tecken requires an auth token for uploading symbols. Tokens are tied to permissions and also destination. For example, you need one token with "upload symbols" permission to upload release symbols but you need a different token with "upload TRY symbols" permission to upload try symbols. If you had two tokens, they look identical. It's impossible to look at infrastructure configuration and know which is which.

It would be nice if we could append a name to tokens. So instead of a token like e457e12e663c45a68be541758875ae31, we could have something like e457e12e663c45a68be541758875ae31-try or e457e12e663c45a68be541758875ae31-stagetesttry.

This bug covers fleshing out some way of being able to distinguish tokens and how to implement that.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

One approach is to adjust the token middleware to drop - and everything afterwards if it sees it. Then people can label their tokens however they like and it doesn't affect anything.

I think I might go for that since it's a small change and doesn't require us to update the ui.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 2795: bug 1774217: add support for token comments

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #2795: "bug 1774217: add support for token comments" in abb9472.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

This got deployed to production just now in bug #1854172. Marking as FIXED.