Don't output more than one sample for the duration of SLEEPing/idle periods
Categories
(Core :: Gecko Profiler, task, P2)
Tracking
()
People
(Reporter: mozbugz, Unassigned)
References
(Blocks 1 open bug)
Details
As originally suggested by Markus in bug 1633572 (before it was diverted), during AUTO_PROFILER_THREAD_SLEEP periods we could record just one sample, but with a duration (or weight).
This could also potentially be done in long zones of zero/near-zero CPU with identical samples.
This could dramatically reduce the size of profiles with lots of idle threads.
I think the processed profile format already accounts for weights, so the front-end may only need to change its Gecko profile processor. TBC.
|
||
Comment 1•2 years ago
|
||
(In reply to Gerald Squelart [:gerald] (he/him) from comment #0)
I think the processed profile format already accounts for weights, so the front-end may only need to change its Gecko profile processor. TBC.
I think we have some computation that don't use the weight properly. For example we're not sure about the activity graph.
|
||
Comment 2•2 years ago
|
||
I've filed https://github.com/firefox-devtools/profiler/issues/4101 to discuss any format changes we want for this.
Description
•