177436 - User matching shouldn't be case-sensitive

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Dave Miller [:justdave]]

On bugzilla-tip on landfill (with usermatchtype in params set to "search" rather
than "wildcard"), I entered "miller" in the CC field on a bug and hit Commit.

I was prompted with several choices, none of which were me.  The ones I got all
had "miller" as part of their email address as well.

I went back and changed it to "Miller" and this time it found me.

Comment 1

[Erik Stambaugh]

Attachment: Changes INSTR in queries to LIKE for case insensitivity

INSTR in mysql < 4.0 is case-sensitive, while LIKE is not.

Per a brief discussion on #mozwebtools, this patch moves substring searches to
LIKE rather than INSTR.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 104787 [details] [diff] [review]
Changes INSTR in queries to LIKE for case insensitivity

Works, r=myk.  It's trivial, but I want bbaetz to look it over too, since he
was the one who suggested INSTR as I recall, so wait for his second r= before
checking this in.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Also you should fix the comment on line 138 to say something like "# then try
sub-string search".

Comment 4

[Erik Stambaugh]

Attachment: Same as before, but removes mention of instr

Removed INSTR from comments.

Comment 5

[Bradley Baetz (:bbaetz)]

You need to escape literal \, %, and _ if you use LIKE. sqlquote does \, but not
the others.

I don't reacall mentioning using substring, but istm that it would be faster
than LIKE. The correct way to do case insensitive substring stuff is to do
SUBSTRING(TOUPPER(foo), $bar).

Comment 6

[Bradley Baetz (:bbaetz)]

(where $bar is capitalised in advance in perl)

Comment 7

[Erik Stambaugh]

Attachment: Case-insensitive INSTR

That's absolutely a better way of doing it.  I presume you meant INSTR rather
than SUBSTRING.

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 105093 [details] [diff] [review]
Case-insensitive INSTR

2xr= justdave

Tested on landfill, it works.

a= justdave for checkin during 2.17.1 freeze

Comment 9

[Joel Peshkin]

Checked in for not_erik

Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.6; previous revision: 1.5
done

Comment 10

[Bradley Baetz (:bbaetz)]

I did, yes

pg doesn't have INSTR, so you should use: |position($bar in toupper(foo)) > 0|
which is standard sql. Except that oracle doesn't appear to have 'position', so
leave it as is, and we'll deal with it later.

Comment 11

[Bradley Baetz (:bbaetz)]

oops...