Closed Bug 1774422 Opened 4 years ago Closed 4 years ago

[Colorway Closet - about:addons] Fix missing dynamic collection header and subheader

Categories

(Firefox :: Theme, defect, P1)

defect
Points:
2

Tracking

()

RESOLVED FIXED
103 Branch
Tracking Status
firefox103 --- fixed

People

(Reporter: kpatenio, Assigned: kpatenio)

References

Details

(Whiteboard: fidefe-colorway-closet )

Attachments

(1 external file)

Bug 1771326 modifies slight how the l10n ids are passed from BuiltInThemes.findActiveColorCollection(). Unfortunately my patch for Bug 1770465 does not take this into consideration (an error from my end) and should be fixed.

STR:

  1. Be sure browser.theme.colorway-closet is enabled. (If not, enable it and reset browser)
  2. Go to about:addons

Expected - See text for header and subheader in Colorway Closet card
Actual - See no text for header and subheader in Colorway Closet card

Assignee: nobody → kpatenio
Severity: -- → S3
Status: NEW → ASSIGNED
Points: --- → 2
Priority: -- → P1
Whiteboard: fidefe-colorway-closet
Pushed by kpatenio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41d8d578bfd1 fix missing colorway header and subheader in about:addons. r=dao,rpl
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
Flags: qe-verify+

I was able to reproduce the issue on Win10 using build 103.0a1(15th of June) and verified as fixed on latest 103.0b5.
But on Ubuntu 20.4 using latest Beta 103.0b5 the about:addons page gets stuck on Extensions after setting the pref from description. similar behavior on Mac 10.13. Is the feature/fix intended for Ubuntu20.4/Mac10.13? Thank you.

Flags: needinfo?(kpatenio)

(In reply to Monica Chiorean from comment #4)

I was able to reproduce the issue on Win10 using build 103.0a1(15th of June) and verified as fixed on latest 103.0b5.
But on Ubuntu 20.4 using latest Beta 103.0b5 the about:addons page gets stuck on Extensions after setting the pref from description. similar behavior on Mac 10.13. Is the feature/fix intended for Ubuntu20.4/Mac10.13? Thank you.

Hi Monica, thanks for bringing this to my attention. The behaviour you described is not supposed to happen. I will look into this.

Flags: needinfo?(kpatenio)

(In reply to Monica Chiorean from comment #4)

Follow-up: turns out that any features related to browser.theme.colorway-closet are only available on Nightly for the time being, considering that localization resources are only included on Nightly. Changes with the pref enabled are only ready to be tested once we ship those resources to Beta; I created Bug 1778556 to track this.

(In reply to kpatenio from comment #6)

(In reply to Monica Chiorean from comment #4)

Follow-up: turns out that any features related to browser.theme.colorway-closet are only available on Nightly for the time being, considering that localization resources are only included on Nightly. Changes with the pref enabled are only ready to be tested once we ship those resources to Beta; I created Bug 1778556 to track this.

Based on your comment is there anything else I should test now for this issue on Beta 103? or we can close it?
Also, I verified on latest Nightly 104.0a1 (20220708093332) on Win10/Ubuntu20.4/Mac10.13 and issue is fixed. Thank you.

Flags: needinfo?(kpatenio)

(In reply to Monica Chiorean from comment #7)

(In reply to kpatenio from comment #6)

(In reply to Monica Chiorean from comment #4)

Follow-up: turns out that any features related to browser.theme.colorway-closet are only available on Nightly for the time being, considering that localization resources are only included on Nightly. Changes with the pref enabled are only ready to be tested once we ship those resources to Beta; I created Bug 1778556 to track this.

Based on your comment is there anything else I should test now for this issue on Beta 103?

No. This feature is under active development and this bug doesn't need verification.

Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(kpatenio)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: