Open Bug 1774508 Opened 3 years ago Updated 3 years ago

[wpt-sync] Sync PR 34460 - Revert "[WPT] BFCache: service worker clients"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(Not tracked)

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 34460 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/34460
Details from upstream follow.

Phillis Tang <phillis@chromium.org> wrote:

Revert "[WPT] BFCache: service worker clients"

This reverts commit 756b8281b5b76b2ae4561d3cf8c29a46689cf23f.

Reason for revert: New tests are very flaky. Example:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVylgELEgVGbGFrZSKKAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jb250cm9sbGVkLWFmdGVyLXJlc3RvcmUuaHR0cHMuaHRtbAw

https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyjgELEgVGbGFrZSKCAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jbGllbnRzLW1hdGNoYWxsLmh0dHBzLmh0bWwM

Original change's description:

[WPT] BFCache: service worker clients

This CL adds service worker tests for BFCache:

  • navigator.serviceWorker.controller
  • Fetch interception
  • Clients.claim()
  • Clients.matchAll() and
  • unregister().

Expected behavior:

  • Controlled pages should remain controlled after
    restored from BFCache, i.e.
    navigator.serviceWorker.controller should remain non-null
    and fetch should be intercepted.
  • Clients.claim() should evict pages
    that would be affected from BFCache.
  • Clients.matchAll() shouldn't list pages in BFCache.
  • unregister() should evict controlled pages from BFCache.

Failing tests:

  • service-worker-clients-claim.https.html:
    On Safari/Firefox, Clients.claim() doesn't evict pages from BFCache.
  • service-worker-controlled-after-restore.https.html:
    On Firefox, fetches are not intercepted after restored from
    BFCache while navigator.serviceWorker.controller is non-null.
  • service-worker-unregister.https.html:
    Controlled pages aren't evicted by unregister() (all browsers).

Bug: 1107415, 1204228, https://github.com/w3c/ServiceWorker/issues/1594
Change-Id: I73233cf917e31dd91b974823d5490d0190f0eade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201011
Reviewed-by: Rakina Zata Amni \<rakina@chromium.org>
Reviewed-by: Ben Kelly \<wanderview@chromium.org>
Commit-Queue: Hiroshige Hayashizaki \<hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1008327}

Bug: 1107415, 1204228, https://github.com/w3c/ServiceWorker/issues/1594
Change-Id: I56ac20a492e2b1716d27867dc9c113b097833a6c

Reviewed-on: https://chromium-review.googlesource.com/3708190
WPT-Export-Revision: 59fb0043f113a55cc191d4074fcd2f8193792f71

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 24 tests and 2 subtests

Status Summary

Firefox

OK : 23
PASS : 28
FAIL : 8
PRECONDITION_FAILED: 12
TIMEOUT : 2

Chrome

OK : 23
PASS : 27
FAIL : 3
PRECONDITION_FAILED: 18
TIMEOUT : 2

Safari

OK : 20
PASS : 19
FAIL : 23
TIMEOUT : 8
NOTRUN : 3

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

You need to log in before you can comment on or make changes to this bug.