1774522 - Make Skia C++20 compatible by replacing deprecated std::result_of_t

Status: RESOLVED FIXED

(Core :: Graphics, task, P3)

Description

[Chris Peterson [:cpeterson]]

The C++ std library functions std::result_of and std::result_of_t were deprecated in C++17 and removed in C++20.

Upstream Skia removed use of std::result_of_t in 2021, so we can just copy upstream's new replacement code:

https://skia.googlesource.com/skia/+/7d8cdd5b7f277f3b661e1eea067cf45a467572c6%5E%21/
https://skia.googlesource.com/skia/+/dc976a96ea388ae49fd0ce18d5a07d8fc15779cf%5E%21/

Because we're just extracting code from upstream, our local changes here can be safely overwritten whenever we next vendor a new Skia version.

Comment 1

[Chris Peterson [:cpeterson]]

Green try build:

https://treeherder.mozilla.org/jobs?repo=try&revision=6f5a851a6ad4087bd3a0a646ff6cf66abd076b88

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1774522 - Make Skia C++20 compatible by replacing deprecated std::result_of_t. r?lsalzman

The C++ std library functions std::result_of and std::result_of_t were deprecated in C++17 and removed in C++20.

Upstream Skia removed use of std::result_of_t in 2021, so we can just copy upstream's new replacement code:

https://skia.googlesource.com/skia/+/7d8cdd5b7f277f3b661e1eea067cf45a467572c6%5E%21/
https://skia.googlesource.com/skia/+/dc976a96ea388ae49fd0ce18d5a07d8fc15779cf%5E%21/

Because we're just extracting code from upstream, our local changes here can be safely overwritten whenever we next vendor a new Skia version.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac706e426c10
Make Skia C++20 compatible by replacing deprecated std::result_of_t. r=lsalzman

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ac706e426c10