1774565 - ExampleCrashHandler crashes on API 31+

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Petru-Mugurel Lingurar [:petru]]

Can be tested on an API31 device with accessing about:crashparent.
Result:

java.lang.RuntimeException: Unable to start service org.mozilla.geckoview_example.ExampleCrashHandler@24789bf with Intent { act=org.mozilla.gecko.ACTION_CRASHED cmp=org.mozilla.geckoview_example/.ExampleCrashHandler (has extras) }: java.lang.IllegalArgumentException: org.mozilla.geckoview_example: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.

 

This happens probably because of - https://developer.android.com/about/versions/12/behavior-changes-12

If your app targets Android 12, you must specify the mutability of each PendingIntent object that your app creates. This additional requirement improves your app's security.

 

Fenix/Focus/AC had to do similar updates related to the immutability flags (eg - https://github.com/mozilla-mobile/android-components/issues/10641)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1743469

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:agi, since you are the author of the regressor, bug 1743469, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1774565 - Pass FLAG_IMMUTABLE in pendingIntents.

This is a requirement when targeting Android 31 and above:
https://developer.android.com/about/versions/12/behavior-changes-12.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/062e66ba89e4
Pass FLAG_IMMUTABLE in pendingIntents. r=calu

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/062e66ba89e4

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1743469